fix(form-control): fix disabled placeholder color#5752
Merged
mcoker merged 5 commits intopatternfly:mainfrom Aug 3, 2023
Merged
fix(form-control): fix disabled placeholder color#5752mcoker merged 5 commits intopatternfly:mainfrom
mcoker merged 5 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-pr-5752.surge.sh A11y report: https://patternfly-pr-5752-a11y.surge.sh |
6457802 to
5e1fd8f
Compare
thatblindgeye
approved these changes
Jul 31, 2023
mcoker
reviewed
Jul 31, 2023
Comment on lines
272
to
274
| &:disabled { | ||
| --#{$form-control}--Color: var(--#{$form-control}--m-disabled--Color); | ||
| } |
Contributor
There was a problem hiding this comment.
Another way you could do this is define the placeholder color when disabled.
diff --git a/src/patternfly/components/FormControl/form-control.scss b/src/patternfly/components/FormControl/form-control.scss
index 6d8e95996..a5bd1b2a2 100644
--- a/src/patternfly/components/FormControl/form-control.scss
+++ b/src/patternfly/components/FormControl/form-control.scss
@@ -206,6 +206,7 @@
&.pf-m-disabled {
--#{$form-control}--BackgroundColor: var(--#{$form-control}--m-disabled--BackgroundColor);
--#{$form-control}--Color: var(--#{$form-control}--m-disabled--Color);
+ --#{$form-control}--m-placeholder--Color: var(--#{$form-control}--m-disabled--Color);
--#{$form-control}__toggle-icon--Color: var(--#{$form-control}--m-disabled__toggle-icon--Color);
--#{$form-control}--before--BorderStyle: none;
--#{$form-control}--after--BorderStyle: none;
mcoker
requested changes
Aug 2, 2023
Comment on lines
280
to
281
| } | ||
| } |
Contributor
There was a problem hiding this comment.
nit - looks like some extra whitespace was added here
Suggested change
| } | |
| } | |
| } | |
| } |
Collaborator
|
🎉 This PR is included in version 5.1.0-prerelease.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
Dec 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
pf-m-placeholderto a disabled form control to test.This also removes the color set on the child of a select - this didn't seem to do anything anywhere so please comment if you know the original purpose of this.
Fixes #5629