Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(build): updated packages, stylelint cleanups#6087

Merged
mcoker merged 2 commits intopatternfly:mainfrom
mcoker:issue-6086
Nov 30, 2023
Merged

chore(build): updated packages, stylelint cleanups#6087
mcoker merged 2 commits intopatternfly:mainfrom
mcoker:issue-6086

Conversation

@mcoker
Copy link
Contributor

@mcoker mcoker commented Nov 29, 2023

fixes #6086

  • removed stylelint-config-standard because stylelint-config-standard-scss includes it.
  • replaced CSS comments for enabling/disabling stylelint to scss comments so they don't end up in the compiled CSS
  • updated packages with ncu --upgrade
  • added a custom stylelint rule for multiple colons after a custom property in a declaration. Now it gives this error, though the server still crashes
    src/patternfly/components/Button/button.scss
     5:28  ✖  Unexpected value ": var(--#{$pf-global}--spacer--form-element)" for property "--#{$button}--PaddingTop"  declaration-property-value-disallowed-list
    
    1 problem (1 error, 0 warnings)
    

@mcoker mcoker requested a review from nicolethoen November 29, 2023 18:40
@patternfly-build
Copy link
Collaborator

patternfly-build commented Nov 29, 2023

@mcoker mcoker merged commit 48bde27 into patternfly:main Nov 30, 2023
@patternfly-build
Copy link
Collaborator

🎉 This PR is included in version 5.2.0-prerelease.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@patternfly-build
Copy link
Collaborator

🎉 This PR is included in version 5.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@patternfly-build
Copy link
Collaborator

🎉 This PR is included in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update packages, a couple of stylelint cleanups

3 participants