chore(Card): convert Card react demos to TS#9561
Merged
tlabaj merged 2 commits intopatternfly:mainfrom Oct 13, 2023
Merged
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-9561.surge.sh A11y report: https://patternfly-react-pr-9561-a11y.surge.sh |
thatblindgeye
requested changes
Sep 5, 2023
Contributor
thatblindgeye
left a comment
There was a problem hiding this comment.
Some comments/pretty quick updates below. Could we also create separate files for these demos in a demos/examples/CardDemos directory?
2596e0a to
21e4256
Compare
thatblindgeye
approved these changes
Sep 26, 2023
e243aa0 to
f6de4eb
Compare
tlabaj
approved these changes
Oct 12, 2023
Contributor
tlabaj
left a comment
There was a problem hiding this comment.
LGTM. Just needs a rebase.
WIP card demo conversion chore(card): convert all demos to ts Apply function name suggestions from Eric Co-authored-by: Eric Olkowski <[email protected]> split up demos, PR feedback from Eric revert card view location and update name fix card view data paths fix tokens imports fix tokens import paths update import style to fix build fix import path add styling updates from main
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #9374
Converted remaining Card react demos to TS and fixed various linting / type errors