Conversation
🦋 Changeset detectedLatest commit: 9739b97 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
==========================================
+ Coverage 83.93% 84.34% +0.41%
==========================================
Files 33 33
Lines 1338 1367 +29
Branches 323 334 +11
==========================================
+ Hits 1123 1153 +30
+ Misses 210 209 -1
Partials 5 5
Continue to review full report at Codecov.
|
| "@preconstruct/cli": patch | ||
| --- | ||
|
|
||
| Add `newDistFilenames` experimental flag |
There was a problem hiding this comment.
this PR has added distFilenameStrategy as well, probably worth mentioning here
There was a problem hiding this comment.
distFilenameStrategy is behind the newDistFilenames flag, will mention it in the changeset that unflags it
There was a problem hiding this comment.
oh ok - i've missed this when skimming through the implementation, wouldn't it make more sense to have this under experimental key?
There was a problem hiding this comment.
The intent is for distFilenameStrategy to be a very well-supported API(once newDistFilenames is unflagged in v2) since people might not want to change their dist filenames for a while/ever
There was a problem hiding this comment.
Sure, once it newDistFilenames gets unflagged - then this makes sense to me, but at the moment it's somewhat confusing to have a top-level option that is only enabled with an experimental flag. Not a big deal - but this has caught my completely off guard.
Closes #244