Problem/Motivation

From @catch on Slack:

We moved stable to contrib because the recommended way to make new themes was via starterkit - #3309392: Stable theme has been removed from core

But at that point left stable9 in.

There is no stable10 because of starterkit. I'm not sure why core should provide stable9 when it's not going to provide stable10 or stable11, so it could move to contrib.

Steps to reproduce

Proposed resolution

Deprecate Stable 9 in Drupal 11 and move to contrib.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3512287

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

markconroy created an issue. See original summary.

andypost’s picture

markconroy’s picture

When creating custom themes, I quite like the process of just creating the bare minimum

  • theme.info.yml
  • theme.libraries.yml
  • CSS + JS + templates as needed
  • everything else inheriting from Stable9 or some other base theme

This means the custom theme directory is as small as possible and very easy to find your way around. Removing Stable9 would mean a change to this process. I'm not against that, but I would guess there are others that have the same process and maybe do not want a copy of every template, for example, in their custom themes.

quietone’s picture

Title: Should we deprecate Stable9? » [policy, no patch] Should we deprecate Stable9?

If deprecated is the intention to move it to a contributed project or just delete?

catch’s picture

@quietone we'd need to move it to a contributed project as we did for stable.

quietone’s picture

Title: [policy, no patch] Should we deprecate Stable9? » [policy, no patch] Deprecate Stable9 and move to contrib
Issue summary: View changes
Issue tags: +Needs product manager review, +Needs framework manager review, +Needs release manager review

@catch, thanks.

Adding tags. Since @markconroy is the Stable9 maintainer, this already has subsystem maintainer approval.

nicxvan’s picture

I don't know that markconroy is in favor, I think he created this to track catch's discussion, but I don't want to speak for him.

markconroy’s picture

I'm not totally against this idea, but I'm also not totally for it either. As @nicxvan said, I created the issue to track @catch's discussion and so that it wouldn't get lost in the Slack history.

nicxvan’s picture

Adding tag back in that case.

markconroy’s picture

Thinking about this further, if the future way to create themes is the starterkit method, then my "create the bare minimum and just overrides the templates that you want" is a moot point.

So I guess this proposal to deprecate Stable9 and move it to contrib has my approval (as subsystem maintainer).

Removing "Needs subsystem maintainer review" tag.

2pha’s picture

I am in the same boat and have been subtheming stable9 for the past few years.
The "create the bare minimum and just overrides the templates that you want" reasoning is what I liked about doing it this way.
Just me chiming in incase it's relevant.

catch’s picture

catch’s picture

Issue tags: +11.4.0 release target

Tagging for 11.4.0 release target because if we get this done, we can remove it in 12.0, otherwise it will need to wait until Drupal 13.

Reminded of this because every time we move some CSS around, stable9 tests fail unless you also move the CSS around in stable9, e.g. #3565297: Move 'display link' CSS to its own views library.

quietone’s picture

Issue tags: -11.4.0 release target +11.4.0 priority
catch’s picture

Removing the RM review tag, this will make theme improvements easier to work on in core without having to keep track of a relatively complex bc layer and duplicate files.

quietone’s picture

Issue tags: - +11.4.0 release priority
nod_’s picture

+1 to remove, we have starterkit and we don't want to have to maintain this in core.

gábor hojtsy’s picture

All the arguments point to it being the most logical step to remove it, so signing off as a Drupal core product manager too.

markconroy changed the visibility of the branch 3512287-policy-no-patch to hidden.

markconroy’s picture

Ignore my branch and work. I got trigger happy and started removing Stable9 instead of deprecating it. I'll close that MR for now.

quietone’s picture

Status: Active » Reviewed & tested by the community

All the sign-off have been given here.

quietone’s picture

The work to deprecate this is being done in #3560200: [meta] Tasks to deprecate Stable 9

xmacinfo’s picture

I am sad about this move and I hate the Starterkit method.

I like (like #3) creating a theme based on Stable or any other existing theme, so that I don't need to start from scratch.

I appreciate Classy and Stable in the contrib form, but once in contrib, development and enhancements drops to almost zero.

Well, moving stable9 to contrib will make it very stable.

catch’s picture

stable9 doesn't include any CSS or templates that core doesn't ship with itself, so it is really the same as starting from scratch, the difference is in stable9 the CSS and templates don't get updated for core improvements (except when it does sometimes to fix bugs etc.)

longwave’s picture

Starterkit has stable9 set as its base theme?!

name: Starterkit theme
type: theme
'base theme': stable9
xmacinfo’s picture

We might deprecate Starterkit as well.

markconroy’s picture

@xmacinfo when creating a new project now, I create two themes - one from starterkit called for example markconroy_base and one that is a minimal theme which uses markconroy_base as its base theme, for example markconroy. Then any custom templates/CSS/etc that I need are placed in the markconroy theme.

It's not as clean as just using Stable9 for the base theme, but it's pretty close to it.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

catch’s picture

Status: Reviewed & tested by the community » Fixed

#3560200: [meta] Tasks to deprecate Stable 9 is open so I think we can mark this one fixed.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.