Problem/Motivation
From @catch on Slack:
We moved stable to contrib because the recommended way to make new themes was via starterkit - #3309392: Stable theme has been removed from core
But at that point left stable9 in.
There is no stable10 because of starterkit. I'm not sure why core should provide stable9 when it's not going to provide stable10 or stable11, so it could move to contrib.
Steps to reproduce
Proposed resolution
Deprecate Stable 9 in Drupal 11 and move to contrib.
Remaining tasks
User interface changes
Introduced terminology
API changes
Data model changes
Release notes snippet
Issue fork drupal-3512287
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3512287-policy-no-patch
changes, plain diff MR !14323
Comments
Comment #2
andypostComment #3
markconroy commentedWhen creating custom themes, I quite like the process of just creating the bare minimum
This means the custom theme directory is as small as possible and very easy to find your way around. Removing Stable9 would mean a change to this process. I'm not against that, but I would guess there are others that have the same process and maybe do not want a copy of every template, for example, in their custom themes.
Comment #4
quietone commentedIf deprecated is the intention to move it to a contributed project or just delete?
Comment #5
catch@quietone we'd need to move it to a contributed project as we did for stable.
Comment #6
quietone commented@catch, thanks.
Adding tags. Since @markconroy is the Stable9 maintainer, this already has subsystem maintainer approval.
Comment #7
nicxvan commentedI don't know that markconroy is in favor, I think he created this to track catch's discussion, but I don't want to speak for him.
Comment #8
markconroy commentedI'm not totally against this idea, but I'm also not totally for it either. As @nicxvan said, I created the issue to track @catch's discussion and so that it wouldn't get lost in the Slack history.
Comment #9
nicxvan commentedAdding tag back in that case.
Comment #10
markconroy commentedThinking about this further, if the future way to create themes is the starterkit method, then my "create the bare minimum and just overrides the templates that you want" is a moot point.
So I guess this proposal to deprecate Stable9 and move it to contrib has my approval (as subsystem maintainer).
Removing "Needs subsystem maintainer review" tag.
Comment #11
2phaI am in the same boat and have been subtheming stable9 for the past few years.
The "create the bare minimum and just overrides the templates that you want" reasoning is what I liked about doing it this way.
Just me chiming in incase it's relevant.
Comment #12
catchPer #3158669-49: [Policy] By default deprecate non-experimental modules that are used by less 5% of sites before the next major version stable9 is used on approximately 2.8% of Drupal 11 sites.
Comment #13
catchTagging for 11.4.0 release target because if we get this done, we can remove it in 12.0, otherwise it will need to wait until Drupal 13.
Reminded of this because every time we move some CSS around, stable9 tests fail unless you also move the CSS around in stable9, e.g. #3565297: Move 'display link' CSS to its own views library.
Comment #14
quietone commentedComment #15
catchRemoving the RM review tag, this will make theme improvements easier to work on in core without having to keep track of a relatively complex bc layer and duplicate files.
Comment #16
quietone commentedComment #17
nod_+1 to remove, we have starterkit and we don't want to have to maintain this in core.
Comment #18
gábor hojtsyAll the arguments point to it being the most logical step to remove it, so signing off as a Drupal core product manager too.
Comment #21
markconroy commentedIgnore my branch and work. I got trigger happy and started removing Stable9 instead of deprecating it. I'll close that MR for now.
Comment #23
quietone commentedAll the sign-off have been given here.
Comment #24
quietone commentedThe work to deprecate this is being done in #3560200: [meta] Tasks to deprecate Stable 9
Comment #25
xmacinfoI am sad about this move and I hate the Starterkit method.
I like (like #3) creating a theme based on Stable or any other existing theme, so that I don't need to start from scratch.
I appreciate Classy and Stable in the contrib form, but once in contrib, development and enhancements drops to almost zero.
Well, moving
stable9to contrib will make it very stable.Comment #26
catchstable9 doesn't include any CSS or templates that core doesn't ship with itself, so it is really the same as starting from scratch, the difference is in stable9 the CSS and templates don't get updated for core improvements (except when it does sometimes to fix bugs etc.)
Comment #27
longwaveStarterkit has stable9 set as its base theme?!
Comment #28
xmacinfoWe might deprecate Starterkit as well.
Comment #29
markconroy commented@xmacinfo when creating a new project now, I create two themes - one from starterkit called for example
markconroy_baseand one that is a minimal theme which uses markconroy_base as its base theme, for examplemarkconroy. Then any custom templates/CSS/etc that I need are placed in themarkconroytheme.It's not as clean as just using Stable9 for the base theme, but it's pretty close to it.
Comment #31
catch#3560200: [meta] Tasks to deprecate Stable 9 is open so I think we can mark this one fixed.