Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Return Resource.K8sContainer when autodetecting resource type #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 16, 2021
Merged

fix: Return Resource.K8sContainer when autodetecting resource type #641

merged 2 commits into from
Sep 16, 2021

Conversation

@wildhemp
Copy link
Contributor

@wildhemp wildhemp commented Aug 25, 2021

According to https://cloud.google.com/stackdriver/docs/solutions/gke/migration#resource-changes container is legacy the new type is k8s_container.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@wildhemp wildhemp requested review from a team as code owners August 25, 2021 17:02
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging API. label Aug 25, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 25, 2021
@simonz130 simonz130 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2021
@simonz130 simonz130 added the automerge Merge the pull request once unit tests and other checks pass. label Sep 10, 2021
@gcf-merge-on-green
Copy link

gcf-merge-on-green bot commented Sep 10, 2021

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 10, 2021
@minherz minherz mentioned this pull request Sep 13, 2021
Closed
@simonz130 simonz130 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 14, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 14, 2021
@simonz130 simonz130 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 14, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 14, 2021
@simonz130 simonz130 merged commit 6103560 into googleapis:master Sep 16, 2021
@wildhemp wildhemp deleted the patch-1 branch September 16, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@simonz130 simonz130 simonz130 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@simonz130 simonz130

Labels

api: logging Issues related to the googleapis/java-logging API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wildhemp @simonz130 @yoshi-kokoro