fix: SessionNotFound was not retried for AsyncTransactionManager #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #552 +/- ##
============================================
+ Coverage 83.93% 84.06% +0.13%
- Complexity 2501 2504 +3
============================================
Files 141 141
Lines 13766 13806 +40
Branches 1315 1317 +2
============================================
+ Hits 11554 11606 +52
+ Misses 1667 1654 -13
- Partials 545 546 +1
Continue to review full report at Codecov.
|
rajatbhatta
pushed a commit
to rajatbhatta/java-spanner
that referenced
this pull request
Nov 17, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SessionNotFoundExceptionwas not retried if these happened when usingAsyncTransactionManager. These exceptions are now handled explicitly in the following way:SessionNotFoundExceptionis translated to anAbortedException, which again will be retried, assuming that the client application has implemented a normal retry loop, as is required when using anAsyncTransactionManager.