Fix coverity scan warnings

yatsukhnenko · yatsukhnenko · commit 6f7ddd275a00 · 2018-11-07T14:03:35.000+02:00
diff --git a/redis_array_impl.c b/redis_array_impl.c
@@ -77,7 +77,11 @@ ra_load_hosts(RedisArray *ra, HashTable *hosts, long retry_interval, zend_bool b
         if (!b_lazy_connect)
         {
             /* connect */
-            redis_sock_server_open(redis->sock TSRMLS_CC);
+            if (redis_sock_server_open(redis->sock TSRMLS_CC) < 0) {
+                zval_dtor(&z_cons);
+                ra->count = ++i;
+                return NULL;
+            }
         }
 
         ra->count = ++i;
diff --git a/redis_session.c b/redis_session.c
@@ -209,7 +209,9 @@ redis_pool_get_sock(redis_pool *pool, const char *key TSRMLS_DC) {
             if (rpm->auth && rpm->redis_sock->status != REDIS_SOCK_STATUS_CONNECTED) {
                     needs_auth = 1;
             }
-            redis_sock_server_open(rpm->redis_sock TSRMLS_CC);
+            if (redis_sock_server_open(rpm->redis_sock TSRMLS_CC) < 0) {
+                continue;
+            }
             if (needs_auth) {
                 redis_pool_member_auth(rpm TSRMLS_CC);
             }

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,11 @@ ra_load_hosts(RedisArray ra, HashTable hosts, long retry_interval, zend_bool b`
`77`	`77`	`if (!b_lazy_connect)`
`78`	`78`	`{`
`79`	`79`	`/* connect */`
`80`		`- redis_sock_server_open(redis->sock TSRMLS_CC);`
	`80`	`+ if (redis_sock_server_open(redis->sock TSRMLS_CC) < 0) {`
	`81`	`+ zval_dtor(&z_cons);`
	`82`	`+ ra->count = ++i;`
	`83`	`+ return NULL;`
	`84`	`+ }`
`81`	`85`	`}`
`82`	`86`
`83`	`87`	`ra->count = ++i;`
Original file line number	Diff line number	Diff line change
`@@ -209,7 +209,9 @@ redis_pool_get_sock(redis_pool pool, const char key TSRMLS_DC) {`
`209`	`209`	`if (rpm->auth && rpm->redis_sock->status != REDIS_SOCK_STATUS_CONNECTED) {`
`210`	`210`	`needs_auth = 1;`
`211`	`211`	`}`
`212`		`- redis_sock_server_open(rpm->redis_sock TSRMLS_CC);`
	`212`	`+ if (redis_sock_server_open(rpm->redis_sock TSRMLS_CC) < 0) {`
	`213`	`+ continue;`
	`214`	`+ }`
`213`	`215`	`if (needs_auth) {`
`214`	`216`	`redis_pool_member_auth(rpm TSRMLS_CC);`
`215`	`217`	`}`