Tests for doubling up on pipeline/multi calls

michael-grunder · michael-grunder · commit 77aebadc73a0 · 2017-08-14T15:06:57.000-07:00
diff --git a/tests/RedisClusterTest.php b/tests/RedisClusterTest.php
@@ -33,6 +33,7 @@ public function testWait()     { return $this->markTestSkipped(); }
     public function testSelect()   { return $this->markTestSkipped(); }
     public function testReconnectSelect() { return $this->markTestSkipped(); }
     public function testMultipleConnect() { return $this->markTestSkipped(); }
+    public function testDoublePipeNoOp() { return $this->markTestSkipped(); }
 
     /* Load our seeds on construction */
     public function __construct() {
diff --git a/tests/RedisTest.php b/tests/RedisTest.php
@@ -2554,6 +2554,31 @@ public function testPipelineMultiExec()
         $this->assertEquals(5, count($ret)); // should be 5 atomic operations
     }
 
+    /* Github issue #1211 (ignore redundant calls to pipeline or multi) */
+    public function testDoublePipeNoOp() {
+        /* Only the first pipeline should be honored */
+        for ($i = 0; $i < 6; $i++) {
+            $this->redis->pipeline();
+        }
+
+        /* Set and get in our pipeline */
+        $this->redis->set('pipecount','over9000')->get('pipecount');
+
+        $data = $this->redis->exec();
+        $this->assertEquals(Array(true,'over9000'), $data);
+
+        /* Only the first MULTI should be honored */
+        for ($i = 0; $i < 6; $i++) {
+            $this->redis->multi();
+        }
+
+        /* Set and get in our MULTI block */
+        $this->redis->set('multicount', 'over9000')->get('multicount');
+
+        $data = $this->redis->exec();
+        $this->assertEquals(Array(true, 'over9000'), $data);
+    }
+
     protected function sequence($mode) {
         $ret = $this->redis->multi($mode)
             ->set('x', 42)
