Simplify short-circuit logic

michael-grunder · michael-grunder · commit d11724260f6d · 2018-10-17T05:14:02.000-07:00
diff --git a/cluster_library.c b/cluster_library.c
@@ -1421,7 +1421,7 @@ PHP_REDIS_API short cluster_send_command(redisCluster *c, short slot, const char
 
         /* Check response and short-circuit on success or communication error */
         resp = cluster_check_response(c, &c->reply_type TSRMLS_CC);
-        if (resp == 0 || resp == -1) {
+        if (resp <= 0) {
             break;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -1421,7 +1421,7 @@ PHP_REDIS_API short cluster_send_command(redisCluster *c, short slot, const char`
`1421`	`1421`
`1422`	`1422`	`/* Check response and short-circuit on success or communication error */`
`1423`	`1423`	`resp = cluster_check_response(c, &c->reply_type TSRMLS_CC);`
`1424`		`- if (resp == 0 \|\| resp == -1) {`
	`1424`	`+ if (resp <= 0) {`
`1425`	`1425`	`break;`
`1426`	`1426`	`}`
`1427`	`1427`