fix(deno): get yargs working on [email protected] #1799
Merged
+23
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khrj
approved these changes
Nov 9, 2020
|
Hey, could you let me know when a Yargs release ships with these changes? Thanks! |
|
@KhushrajRathod there's one change I'd like to also fix before the release, hope to have something out within the next couple days. |
|
Hey there! Any plans to support |
This was referenced Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets yargs working again on [email protected], by dropping the complex
YargsInstance.Unfortunately
[email protected]seems to break the already fragile path handling logic that was being used to target both Node.js and Deno simultaneously. I'm not sure what the best path forward is, we might want to simply maintain our own type definitions for deno?Refs #1792
Fixes #1794
CC: @ffMathy @KhushrajRathod