I have tested this on client and server, including lots of extra msg()
printing to verify that "the arg that we think should be a multi* or
context* pointer" indeed is what we expect.

v4 was good to go, but it crashes the server if --management-hold is
active and "bytecount 1" is issued (tun not open yet, so parts of the
management infra are not initalized yet - in particular *.callback.arg)

So, v5 is the same as v3, just having an if() clause there.  ASSERT()
for "can't happen" will tell you what you overlooked ;-)

As for the commit before that, mail-archive.org refuses to acknowledge
existence of the "patch on the list!" mail, so sourceforge.net is 
linked.

Your patch has been applied to the master branch.

commit 3bc0b2d0aea742640a1acf97fc4b41726b88ce96
Author: Ralf Lici
Date:   Tue Sep 2 18:00:44 2025 +0200

     management: resync timer on bytecount interval change

     Signed-off-by: Ralf Lici <[email protected]>
     Acked-by: Gert Doering <[email protected]>
     Message-Id: <[email protected]>
     URL: https://sourceforge.net/p/openvpn/mailman/message/59228306/
     Signed-off-by: Gert Doering <[email protected]>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to