Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1179?usp=email
to review the following change.
Change subject: vlan: Limit -Wconversion override to GCC 10 and older
......................................................................
vlan: Limit -Wconversion override to GCC 10 and older
Only Debian 11 complains about this. This way we know
we can remove this at some point.
Change-Id: I73c46ac630834a8cf8894aaa2dcc429fbedd3db7
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M src/openvpn/vlan.c
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/79/1179/1
diff --git a/src/openvpn/vlan.c b/src/openvpn/vlan.c
index 3da470a..f6e2251 100644
--- a/src/openvpn/vlan.c
+++ b/src/openvpn/vlan.c
@@ -43,7 +43,8 @@
return ntohs(hdr->pcp_cfi_vid & OPENVPN_8021Q_MASK_VID);
}
-#if defined(__GNUC__) || defined(__clang__)
+/* ~OPENVPN_8021Q_MASK_VID is "int" on old GCC */
+#if defined(__GNUC__) && __GNUC__ < 11
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wconversion"
#endif
@@ -61,7 +62,7 @@
(hdr->pcp_cfi_vid & ~OPENVPN_8021Q_MASK_VID) | (htons(vid) &
OPENVPN_8021Q_MASK_VID);
}
-#if defined(__GNUC__) || defined(__clang__)
+#if defined(__GNUC__) && __GNUC__ < 11
#pragma GCC diagnostic pop
#endif
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1179?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I73c46ac630834a8cf8894aaa2dcc429fbedd3db7
Gerrit-Change-Number: 1179
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
