fix(dns): return NODATA instead of NXDOMAIN when a name exists with a…#374
Open
lbauer13 wants to merge 2 commits intoacme-dns:masterfrom
Open
fix(dns): return NODATA instead of NXDOMAIN when a name exists with a…#374lbauer13 wants to merge 2 commits intoacme-dns:masterfrom
lbauer13 wants to merge 2 commits intoacme-dns:masterfrom
Conversation
…nother type acme-dns#373 When a TXT exists for a given name but a resolver queries another type, acme-dns will now return NODATA to prevent the resolver from caching a negative response for further TXT queries. It still returns NXDOMAIN if the name does not exist at all.
Author
|
Added tests for authoritative name with various types (NOERROR, 0 or 1 answer) vs. non-authoritative name (NXDOMAIN) |
Author
|
Thanks for the pointer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return NODATA instead of NXDOMAIN when a name exists with another type
Should fix #373
When a TXT exists for a given name but a resolver queries another type, acme-dns will now return NODATA to prevent the resolver from caching a negative response for further TXT queries.
It still returns NXDOMAIN if the name does not exist at all.