Thanks to visit codestin.com
Credit goes to GitHub.com

Skip to content

Conversation

@dariiing
Copy link
Contributor

Hello,
This fixes #2109

@dariiing dariiing added this to the Winter release (2025.12.0) milestone Nov 27, 2025
@dariiing dariiing self-assigned this Nov 27, 2025
@dariiing dariiing added the Ready to Review This PR is ready to be checked by another team member label Nov 27, 2025
davidbenque
davidbenque previously approved these changes Jan 8, 2026
Copy link
Contributor

@davidbenque davidbenque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI seems OK in the ctrl-e modal. Would need another quick review to check for unintended consequences.

@davidbenque
Copy link
Contributor

Taking a second look at this. There is no way to get the full title text in languages where the text overflows (aside from the accessibility label which seems correct). This doesn't seem like a good solution but adding tooltips to everything is also not great. Let's discuss the best way to solve this

@davidbenque davidbenque dismissed their stale review January 9, 2026 17:19

reconsidered the accessibility of overflowing text labels

@yflory yflory removed the Ready to Review This PR is ready to be checked by another team member label Jan 12, 2026
Copy link
Contributor

@davidbenque davidbenque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After debating this, the addition of tooltips for all cases does not work as a solution so we will keep the cropped text with icons for context (and the full text is available as a label). So keeping this as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants