Thanks to visit codestin.com
Credit goes to GitHub.com

Skip to content

Conversation

@pgiraud
Copy link
Member

@pgiraud pgiraud commented Nov 14, 2025

No description provided.

@pgiraud
Copy link
Member Author

pgiraud commented Nov 27, 2025

@HyTaXx and @FOBshippingpoint can you please give this pull request a try and give me your opinion?

@FOBshippingpoint
Copy link

@HyTaXx and @FOBshippingpoint can you please give this pull request a try and give me your opinion?

Some feedback:

  • I wish we could have an export icon button next to the delete icon for each plan item. Will save a few clicks when exporting a single plan.
  • The "Select" and "OK" buttons aren't the same width. If you click on the left side of "Select", you still have to move to the right a little to reach "OK".
  • The "created XXX time ago" text updates whenever cursor enters, which feels a bit strange to me. Maybe don't update it or only update it once per minute?

I think these are all small things, feel free to ignore them if it's not worth the effort.

@pgiraud pgiraud force-pushed the home_saved_plans branch 6 times, most recently from 5ff0b83 to e47b7bb Compare December 2, 2025 07:09
@pgiraud
Copy link
Member Author

pgiraud commented Dec 2, 2025

@FOBshippingpoint may I ask you to give it a new try?

@FOBshippingpoint
Copy link

Hi @pgiraud

Great to have duplication detection
Just one little UI inconsistent, I think add ms-1 to the edit button will fix:

圖片
diff --git i/example/src/views/HomeView.vue w/example/src/views/HomeView.vue
index b526161..d9b0dcd 100644
--- i/example/src/views/HomeView.vue
+++ w/example/src/views/HomeView.vue
@@ -497,7 +497,7 @@ function addMessage(text) {
                     <FontAwesomeIcon :icon="faTrash"></FontAwesomeIcon>
                   </button>
                   <button
-                    class="btn btn-sm btn-outline-secondary py-0"
+                    class="btn btn-sm btn-outline-secondary py-0 ms-1"
                     title="Edit plan details"
                     v-on:click.stop="editPlan(plan)"
                   >

Thanks for the work! pev2 indeed helped me a lot in fixing slow queries.

@pgiraud pgiraud force-pushed the home_saved_plans branch 3 times, most recently from 83bf578 to 8813083 Compare December 3, 2025 09:24
@pgiraud pgiraud merged commit 0b1ca3d into master Dec 3, 2025
2 checks passed
@pgiraud pgiraud deleted the home_saved_plans branch December 3, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants