Trust executable bit #2162
Open
Trust executable bit #2162
+20
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In other to reduce the usage of the global `trust_executable_bit`, add a parameter to the function `ce_mode_from_stat()`, that will get passed a repository variable. This commit uses `UNUSED` as the next commit will modify the function to pass the repository parameter. Signed-off-by: Olamide Caleb Bello <[email protected]>
The `core.filemode` setting is stored in a global variable and populated via `repo_cfg_bool()`. This may cause issues when handling more than one repository in a single process with diffrent values for that config key. Refactor the code to store the value in `struct repo-settings`. This help the path towards the libification of Git Signed-off-by: Olamide Caleb Bello <[email protected]>
Member
You will want to delete this before |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for taking the time to contribute to Git! Please be advised that the
Git community does not use github.com for their contributions. Instead, we use
a mailing list ([email protected]) for code submissions, code reviews, and
bug reports. Nevertheless, you can use GitGitGadget (https://gitgitgadget.github.io/)
to conveniently send your Pull Requests commits to our mailing list.
For a single-commit pull request, please leave the pull request description
empty: your commit message itself should describe your changes.
Please read the "guidelines for contributing" linked above!