[WIP] Skip examples or tests that need credentials if not available#484
Draft
[WIP] Skip examples or tests that need credentials if not available#484
Conversation
Member
Author
|
There is no issue for this PR |
Member
Author
|
The package is also too big to be sent via |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## opencpu #484 +/- ##
===========================================
+ Coverage 85.65% 85.67% +0.01%
===========================================
Files 26 26
Lines 746 747 +1
===========================================
+ Hits 639 640 +1
Misses 107 107 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
This seems to have a very negative effect on package coverage, does covr somehow skip these tests as well? It should have access to credentials since it worked just fine before! |
Member
Author
|
CI also has much more skips than expected, something is wrong with my helper and covr caught it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some examples or tests need credentials to be stored in order to run. This is no big deal but will break CRAN submission or using
devtools::check_win_release(). This PR gets this out of the way.I add two helpers, one to check if credentials are set, this is used for conditional examples and for the other function: a testthat skip helper that skips a test if no credentials are set.
It should be easy to adapt these helpers to keyring later on. They may need no modification whatsoever.
Possible followup: Some tests are already skipped if there is no local database connection, in fact, these should also be skipped if there are no credentials set. I suppose I could repeat the skip or call it from within
skip_if_not_localdb().