Enable callbacks during close() #926
Open
+27
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeroyorch
suggested changes
Jan 8, 2026
18c217f to
bdd3566
Compare
aeroyorch
approved these changes
Jan 9, 2026
aeroyorch
approved these changes
Jan 10, 2026
Callbacks can be invoked during curl_easy_cleanup() and curl_multi_remove_handle() so make this possible in pycurl. Fixes: pycurl#748 Fixes: pycurl#865
4df4e4b to
67fa3fe
Compare
aeroyorch
suggested changes
Jan 12, 2026
| self.curl.unsetopt(pycurl.CLOSESOCKETFUNCTION) | ||
|
|
||
| @util.min_libcurl(7, 21, 7) | ||
| def test_closesocketfunction_on_close(app): |
Contributor
There was a problem hiding this comment.
Could we add a new test identical to this one, but deleting the Curl object and calling the gc.collect() and checking that the close callback was not called during dealloc?
| assert(self != NULL); | ||
| assert(PyObject_IsInstance((PyObject *) self, (PyObject *) p_Curl_Type) == 1); | ||
| handle = self->handle; | ||
| self->handle = NULL; |
Contributor
There was a problem hiding this comment.
Why not adding an additional parameter (e.g. cleanup) to util_curl_close to set the self->handle to NULL in case of dealloc:
/* Do not allow callbacks during dealloc */
if (cleanup != 0) {
self->handle = NULL;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callbacks can be invoked during curl_easy_cleanup() and curl_multi_remove_handle() so make this possible in pycurl.
Fixes: #748
Fixes: #865