Update README.md to provide notice of deprecation of legacy C++ API. #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garzaran
previously approved these changes
Mar 28, 2025
maciekpac
reviewed
Mar 31, 2025
nikitaxgusev
reviewed
Apr 1, 2025
nikitaxgusev
reviewed
Apr 1, 2025
nikitaxgusev
reviewed
Apr 1, 2025
Added * to NCCL to refer the reader to the new Notices and Disclaimers section (taken from our release notes) which addresses the trademark owership for NCCL. Used improvements suggested by Nikita.
I learned that I need to use the * only on the first instance of the trademarked name. Removed the second *.
ranukund
reviewed
Apr 2, 2025
Contributor
ranukund
left a comment
There was a problem hiding this comment.
Few edit suggestions for consideration.
ranukund
reviewed
Apr 2, 2025
Co-authored-by: Ranu Kundu <[email protected]>
Co-authored-by: Ranu Kundu <[email protected]>
Co-authored-by: Ranu Kundu <[email protected]>
Co-authored-by: Ranu Kundu <[email protected]>
garzaran
approved these changes
Apr 2, 2025
ranukund
approved these changes
Apr 2, 2025
maciekpac
approved these changes
Apr 3, 2025
Contributor
maciekpac
left a comment
There was a problem hiding this comment.
Looks good. I'm not a legal person and I assume that the necessary steps related to trademarks were taken so I approve but I added two comments/questions in places where I had doubts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added notice of deprecation of the legacy C++ API. Provided link to RFC for NCCL like C API to invite additional comment.