Merged
Conversation
5346510 to
28db0e0
Compare
Contributor
|
Nixpkgs changed so that When I tried to fix that by setting The It seems like this is no longer working. I am also seeing structuredAttrs is incompatible with Things I haven't been able to figure out:
|
28db0e0 to
b79b527
Compare
Contributor
|
This update also seems to make clangd dysfunctional. Still investingating... |
Contributor
|
I can reproduce the (pkgs.hello.overrideAttrs {
__structuredAttrs = true;
}).inputDerivationThis complains about the output not being allowed to refer to output paths. I was suspicious of let
__structuredAttrs = true;
in
derivation ({
inherit __structuredAttrs;
system = "x86_64-linux";
name = "test";
outputs = [ "out" ];
builder = pkgs.stdenv.shell;
args = [
"-c"
''
out="${placeholder "out"}"
echo "$out" > $out
''
];
} // (
let
sharedOutputChecks = {
allowedReferences = null;
};
in
if __structuredAttrs then
{
outputChecks.out = sharedOutputChecks;
}
else
sharedOutputChecks
)
)And it does give the same error! ...But also it gives the same error when |
Member
|
Created a Hydra jobset for this: https://hydra.nixos.org/jobset/nix/pr-14688 |
Contributor
|
Error we're talking about: |
Contributor
foo.nix{
hello_structured_attrs_input_drv = (pkgs.hello.overrideAttrs {
__structuredAttrs = true;
}).inputDerivation;
hello_normal_input_drv = pkgs.hello.inputDerivation;
custom_structured_attrs = derivation {
__structuredAttrs = true;
system = "x86_64-linux";
name = "test";
outputs = [ "out" ];
builder = pkgs.stdenv.shell;
args = [
"-c"
''
out="${placeholder "out"}"
echo "$out" > $out
''
];
outputChecks.out = {
allowedReferences = null;
allowedRequisites = null;
disallowedReferences = [ ];
disallowedRequisites = [ ];
};
};
custom_normal = derivation {
system = "x86_64-linux";
name = "test";
outputs = [ "out" ];
builder = pkgs.stdenv.shell;
args = [
"-c"
''
out="${placeholder "out"}"
echo "$out" > $out
''
];
allowedReferences = null;
allowedRequisites = null;
disallowedReferences = [ ];
disallowedRequisites = [ ];
};
}nix-build commands & outputnix-instantiate commands & output |
Contributor
|
Note that By contrast |
13 tasks
Contributor
Author
|
For now we could do |
Contributor
|
Adding |
Contributor
|
Ooooooh. I was putting it in the wrong place. In any case, But this also means that, apparently, it only applies to top-level attributes not to |
f6c0c11 to
cb4d246
Compare
Contributor
|
I've temporarily switched us to |
Member
|
@Radvendii I think the remaining failures are due to incorrect versions for the "skip if daemon older than" conditions. It is not hard for this thing to happen. I would guess that the functional test failures we have no were not succeeding before, but skipped before. |
Contributor
|
That makes sense for the #13247 test (should we open a new issue for that being broken?) The other errors come from |
b15d412 to
358f7c5
Compare
Radvendii
reviewed
Dec 15, 2025
Comment on lines
-184
to
190
| if isDaemonNewer "2.29pre"; then | ||
| if isDaemonNewer "2.31"; then | ||
| <<<"$out" grepQuiet -E "error: Cannot build '.*-x4\\.drv'" | ||
| <<<"$out" grepQuiet -E "Reason: 1 dependency failed." | ||
| elif isDaemonNewer "2.29pre"; then | ||
| <<<"$out" grepQuiet -E "error: Cannot build '.*-x4\\.drv'" | ||
| <<<"$out" grepQuiet -E "Reason: 1 dependency failed." | ||
| <<<"$out" grepQuiet -E "Build failed due to failed dependency" |
Contributor
There was a problem hiding this comment.
should I remove the last line from the isDaemonNewer "2.29pre" branch instead?
358f7c5 to
c9b1f16
Compare
7d35ba6 to
1ece7b5
Compare
Contributor
|
Made this because big Hydra is overwhelmed right now: https://hydra.nixos-cuda.org/jobset/nix/PR14688 |
Member
|
For reference, you can view jobsets like |
Contributor
Author
There's no Cygwin in the hydra jobset. It's the mingw dependencies that are borked. I already fixed readline, but libcurl needs some massaging. We can probably just disable H2/H3 support and stick with an H1-only build of curl. |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
Btw the readline fix is in NixOS/nixpkgs#472232 |
Member
There isn't a jobset yet but this is looking promising: NixOS/nixpkgs#475998 |
Member
|
About the windows failures, just make sure the wine tests are not failing. |
Contributor
Author
|
Cherry-picked some easy fixes to #15076, will clean up the history here afterwards. |
We don't want too much unnecessary formatting churn.
Also disable some churny formatters on some specific files.
- nghttp3 is not supported on mingw - onetbb doesn't build on mingw - lowdown override is no longer needed, same for toml11
`mc config host add` has been removed SEE: minio/mc#5206
fixed in nixpkgs PR #469652
new version of meson creates some state file
This is no longer necessary and produces an eval warning: > evaluation warning: The 'pie' hardening flag has been removed in favor of enabling PIE by default in compilers and should no longer be used. This was first introduced in 2200f31, but is no longer necessary since the switch to meson.
…stead of readOnlyNixStore This option is not available in 25.11: > Please use the `boot.nixStoreMountOpts' option to define mount options for the Nix store, including 'ro'
a39ae4f to
d690016
Compare
Ericson2314
approved these changes
Jan 26, 2026
Member
Ericson2314
left a comment
There was a problem hiding this comment.
The errors are now close enough for me. The two darwin integration test failure jobs are not immediately clear, and we can fix them after
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
25.11 is out and we should follow suit.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.