Thanks to visit codestin.com
Credit goes to Github.com

Skip to content

Conversation

@clarktsiory
Copy link
Contributor

@clarktsiory clarktsiory commented Dec 19, 2025

https://issues.rudder.io/issues/28055

This PR removes the lift-json import from SettingsApi.scala.
It :

  • adds API tests to endpoints that were missing one
  • replaces the toJson and parseJson method of each setting by an idiomatic "JsonCodec instance" in zio-json
    ➡️ the main change is about adding given JsonCodec[...] in place of lift-json. In some places, we need to use the JSON AST types since the settings are implemented in a generic way

Along the way :

@clarktsiory
Copy link
Contributor Author

Commit modified

@clarktsiory clarktsiory force-pushed the arch_28055/migrate_settingsapi_to_zio_json branch from 714ffc1 to be06578 Compare December 19, 2025 17:44
@clarktsiory clarktsiory force-pushed the arch_28055/migrate_settingsapi_to_zio_json branch from be06578 to ee5dabf Compare December 29, 2025 15:26
@clarktsiory
Copy link
Contributor Author

Commit modified

@clarktsiory clarktsiory force-pushed the arch_28055/migrate_settingsapi_to_zio_json branch from ee5dabf to 9783872 Compare December 29, 2025 16:20
@clarktsiory
Copy link
Contributor Author

Commit modified

@clarktsiory clarktsiory requested a review from P4uline December 29, 2025 16:33
@clarktsiory clarktsiory marked this pull request as ready for review December 29, 2025 16:33
Fixes #28055: Migrate SettingsApi to zio-json
@clarktsiory
Copy link
Contributor Author

PR updated with a new commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant