Thanks to visit codestin.com
Credit goes to Github.com

Skip to content

codewindow: allow opening on setup #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
horriblename merged 8 commits into from
Jan 27, 2026
Merged

codewindow: allow opening on setup #1259

horriblename merged 8 commits into from
Jan 27, 2026

Conversation

@Vagahbond
Copy link
Contributor

@Vagahbond Vagahbond commented Dec 3, 2025 •
edited
Loading

Add an option to open codewindow on NVF launch

Pretty straightforward

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

github-actions bot pushed a commit that referenced this pull request Dec 3, 2025
@actions-user
Deploy PR #1259 preview
d6dc269
@github-actions
Copy link

github-actions bot commented Dec 3, 2025 •
edited
Loading

🚀 Live preview deployed from 100d9e5

View it here:

Debug Information

Triggered by: horriblename

HEAD at: codewindow-open-by-default

Reruns: 1972

NotAShelf
NotAShelf requested changes Dec 3, 2025
View reviewed changes
Copy link
Owner

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather if this plugin was converted to setupOpts.

@Vagahbond
Copy link
Contributor Author

Vagahbond commented Dec 3, 2025

Ill see what I can do with HR

@NotAShelf
Copy link
Owner

NotAShelf commented Dec 3, 2025

Should be trivial, barely a breaking change.

If you don't do it now you are FIRED

@Vagahbond
codewindow: allow opening on setup
232e4a0 
codewindow: allow opening on setup
@Vagahbond Vagahbond force-pushed the codewindow-open-by-default branch from 082e0cd to 232e4a0 Compare December 3, 2025 21:24
@Vagahbond
Copy link
Contributor Author

Vagahbond commented Dec 3, 2025

Please don't fire me I'll make you coffee ☕

@Vagahbond Vagahbond requested a review from NotAShelf December 4, 2025 05:02
@NotAShelf
Copy link
Owner

NotAShelf commented Dec 4, 2025

Ok you're not fired

NotAShelf
NotAShelf previously approved these changes Dec 4, 2025
View reviewed changes
@Soliprem
Copy link
Collaborator

Soliprem commented Dec 7, 2025

CI failure is unrelated

github-actions bot pushed a commit that referenced this pull request Dec 7, 2025
@actions-user
Deploy PR #1259 preview
8ef5100
Soliprem
Soliprem requested changes Dec 7, 2025
View reviewed changes
Copy link
Collaborator

@Soliprem Soliprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the release notes entry (something along the lines of "moved codewindow to setupOpts" should be fine)

@Vagahbond
Copy link
Contributor Author

Vagahbond commented Dec 7, 2025

Will do after breakfast

@Vagahbond
release notes: add line
61634e9 
codewindow: allow opening on setup
@Vagahbond Vagahbond requested a review from Soliprem December 7, 2025 20:37
NotAShelf
NotAShelf requested changes Dec 7, 2025
View reviewed changes
@Vagahbond Vagahbond requested a review from NotAShelf December 7, 2025 22:19
Soliprem
Soliprem previously approved these changes Dec 8, 2025
View reviewed changes
@Vagahbond
Copy link
Contributor Author

Vagahbond commented Dec 9, 2025

Don't merge it's actually broken
Ill fix asap

@Vagahbond Vagahbond requested a review from Soliprem December 11, 2025 09:22
github-actions bot pushed a commit that referenced this pull request Jan 27, 2026
@actions-user
Deploy PR #1259 preview
cc7454b
NotAShelf
NotAShelf previously requested changes Jan 27, 2026
View reviewed changes
Copy link
Owner

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment to address. Please also squash your commits into one that matches our commit style described here

github-actions bot pushed a commit that referenced this pull request Jan 27, 2026
@actions-user
Deploy PR #1259 preview
0516076
@Vagahbond Vagahbond force-pushed the codewindow-open-by-default branch 3 times, most recently from 0dfdc13 to 47bfd0c Compare January 27, 2026 08:05
github-actions bot pushed a commit that referenced this pull request Jan 27, 2026
@actions-user
Deploy PR #1259 preview
0b8b0b6
@NotAShelf @Vagahbond
codewindow: move to setupOpts
2430532 
readme: edit

codewindow: move to setupOpts

readme: edit

format
@Vagahbond Vagahbond force-pushed the codewindow-open-by-default branch from 47bfd0c to 2430532 Compare January 27, 2026 20:22
github-actions bot pushed a commit that referenced this pull request Jan 27, 2026
@actions-user
Deploy PR #1259 preview
51ad6ed
@horriblename horriblename enabled auto-merge (squash) January 27, 2026 22:45
github-actions bot pushed a commit that referenced this pull request Jan 27, 2026
@actions-user
Deploy PR #1259 preview
7bb0e4f
@horriblename horriblename merged commit dacc727 into NotAShelf:main Jan 27, 2026
14 checks passed
@Vagahbond Vagahbond deleted the codewindow-open-by-default branch January 27, 2026 23:15
@NotAShelf
Copy link
Owner

NotAShelf commented Jan 28, 2026

reverting immediately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@horriblename horriblename horriblename approved these changes

@NotAShelf NotAShelf NotAShelf left review comments

@Soliprem Soliprem Awaiting requested review from Soliprem Soliprem is a code owner

Assignees

No one assigned

Labels

topic: documentation topic: modules topic: plugins

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Vagahbond @NotAShelf @Soliprem @horriblename