Make web_responsive compatible with Enterprise Edition #2652
Conversation
|
Not sure what to do about the remaining failed checks:
|
you can run locally
That's quite normal. You are proposing a module that depends on web_enterprise module, that is not available. I think you have to remove this module from your PR and maintain it separately. regards. |
|
Thanks Sylvain, I just ran the pre-commit hooks locally and the check now passes. Regarding the dependency on the web_enterprise module, I understand that the checks will not pass. If it is OCA policy not to host modules that depend on the Enterprise Edition, then I'll remove it from the PR and host it elsewhere as you suggest. However the main point of the PR was to make the |
|
That logic was there, but removed, as it's problematic sometimes. If you put it, it should be an opt-in option. About the reference to the other module outside OCA and depending on enterprise, they can't be done here by the rules. Anyway, note that most of us are pro-community and open source. |
|
Hi Pedro, sure, I can update the PR so as to make this behavior optional. Actually I had already started and I stashed those changes to upload a simpler version of the PR, so it shouldn't be long. What I wasn't able to do however was to force the page to reload when the value of the config field (in the user's preferences) is changed, like it does when the language changes for instance. It seems that this is implemented for some reason in the hr module; I tried to replicate what I found there, but it didn't work. Any idea how to achieve this? |
|
I can't say, sorry, but it's not a big deal. Just let a manual refresh to happen. |
|
If you want send a reload from server to client: https://github.com/odoo/odoo/blob/fb42f0a705c83f263714f13e7d7bc3f46ac2d6b3/odoo/addons/base/models/ir_module.py#L608 If you want simple reload on client side: |
…Edition The web_responsive module per se does work alongside web_enterprise, so I removed the "excludes" from the manifest. I also created a new module, web_responsive_enterprise, that enables the searchable Apps Menu on the Enterprise Edition.
…in the readme directory were enough)
…pecified in the URL Otherwise, direct links to any specific place in Odoo opens the Apps menu instead of directly showing the desired place.
… of Apps Menu configurable in user profile
|
Okay I think the PR is decent now:
Not sure what to do about the code coverage checks, is it a strict requirement that they pass? If so, I'll need help I think. @Tardo wrt the reload, what I was looking for is a concise way to reload the client when a certain field on the res.users model is changed. Returning an action with |
…on_load from "default" to "never" This makes the behavior more explicit
|
Hi. There are conflicts. Could you rebase and solve them ? Thanks ! |
The web_responsive module per se does work alongside web_enterprise, so I removed the "excludes" from the manifest.
I also created a new module, web_responsive_enterprise, that enables the searchable Apps Menu on the Enterprise Edition. I tried to be as little intrusive as possible. I only added a method named
_getInitialOpenStatein the originalAppsMenuso as to keep the original behaviors in each edition: in the Community Edition, the initial app (whatever it is) is displayed at startup, while in the Enterprise Edition, the Apps Menu is displayed at startup.