[17.0][MIG] web_select_all_companies: Migration to 17.0 #2834
Conversation
CRogos
left a comment
There was a problem hiding this comment.
One thing I am not sure. I think, when you click the very first time, it is not working. If I see it correctly, you can also recognize this in the description gif recording.
Could you cleanup the git history according to the migration guide?
|
here is also another PR: #2798 |
5c64c7c to
7b82b9e
Compare
|
@CRogos Merge/squash done . Also in this PR i have tested "when you click the very first time, it is not working" this issue is not there. also i think in the existing PR #2798 branches might not be get selected from this functionality whereas in this PR that issue is also fixed. |
CRogos
left a comment
There was a problem hiding this comment.
Could you fix the commit message and the version number.
Rest LGTM.
Could not reproduce the first click issue eigther.
| "name": "Web Select All Companies", | ||
| "summary": "Allows you to select all companies in one click.", | ||
| "version": "16.0.1.0.1", | ||
| "version": "17.0.1.0.1", |
There was a problem hiding this comment.
version should be 17.0.1.0.0
1dfdc69 to
fc1d06d
Compare
fc1d06d to
aa229e2
Compare
|
@legalsylvain Please review. |
|
Hey! I am the guy from the other PR #2798. I have tested both our implementations on runboat and they are practically the same. Our solution looks very similar. |
|
@legalsylvain @CRogos What is the next step to get this PR merged ? |
|
@Jp-alitec I'll test it if you rebase to get runboat to build. |
| <div | ||
| role="button" | ||
| tabindex="0" | ||
| class="d-flex flex-grow-1 align-items-center py-0 log_into ps-2" |
There was a problem hiding this comment.
| class="d-flex flex-grow-1 align-items-center py-0 log_into ps-2" | |
| class="d-flex flex-grow-1 align-items-center py-0 ps-2" |
IMHO log_intohas to be removed here, since it is (was?) linked to JS event to "log into a company" and it is irrelevant for "All companies".
This comment was marked as outdated.
This comment was marked as outdated.
|
/ocabot rebase |
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-16.0/web-16.0-web_select_all_companies Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_select_all_companies/
|
Congratulations, PR rebased to 17.0. |
aa229e2 to
0393a49
Compare
StefanRijnhart
left a comment
There was a problem hiding this comment.
Tested on runboat: after activating All Companies, deactivating the All Companies option does not work. All companies remain activated. I would expect the main company to be the only selected company after unchecking the option.
|
Please add a future upgrade note in the readme saying Odoo supports this functionality natively in version 18, but only if the user has access to more than nine companies (odoo/odoo@5b597766cd17605). |
|
@Jp-alitec |
Migrated to V17