[16.0][MIG]: web_edit_user_filter: Migration to 16.0 #3007

anusriNPS · 2024-12-02T08:11:52Z

Migrating web_edit_user_filter to 16.0

anusriNPS · 2024-12-03T10:27:01Z

Verified Scenarios:

User able to make a filter as favorite and when tries to click on popover of favorite, it unpacks the filter which is stored as favorite
Similarly, user able to mark groupBy as favorite and able to unpack when click on the popover of the favorite.
When both filter and groupby is marked as favorite, both groupby and filter values are unpacked.
Filter/GroupBy facet on click shows popover and user able to remove filter/groupBy values from popover.
When a new favorite is added, user need not reload the page in order to unpack filter/groupBy from favorites. Warning which is available in 14.0 is no longer needed, so removed it.

Unverified Scenarios:

In unpack_filter function, there is a branch deals with tentative filter/groupBy which could not be verified as not able to understand the feature from README file or in general.
So, I would like to know how this scenario could be verified? Any suggestions would be helpful to verify it.

HekkiMelody · 2024-12-03T13:18:53Z

web_edit_user_filter/models/ir_filters.py

+        for i, res_filter in enumerate(res):
+            # Add the field 'facet' to the result
+            res[i]["facet"] = filters.filtered(lambda f: f.id == res_filter["id"]).facet


suggestion:

Suggested change

for i, res_filter in enumerate(res):

# Add the field 'facet' to the result

res[i]["facet"] = filters.filtered(lambda f: f.id == res_filter["id"]).facet

for res_filter in res:

# Add the field 'facet' to the result

res_filter["facet"] = filters.filtered(lambda f: f.id == res_filter["id"]).facet

HekkiMelody · 2024-12-03T13:26:36Z

web_edit_user_filter/__manifest__.py

+            "web_edit_user_filter/static/src/xml/backend.xml",
+            "web_edit_user_filter/static/src/xml/search_extended.xml",


chore: for consistence,

Suggested change

"web_edit_user_filter/static/src/xml/backend.xml",

"web_edit_user_filter/static/src/xml/search_extended.xml",

"web_edit_user_filter/static/src/xml/*.xml",

HekkiMelody · 2024-12-03T13:59:12Z

web_edit_user_filter/static/src/js/customFavorite.esm.js

+        var searchItems = this.env.searchModel.getSearchItems(
+            (s) => s.type === "favorite"
+        );
+        const favorites = searchItems.filter(
+            (f) => f.description === this.state.description
+        );


suggestion:

Suggested change

var searchItems = this.env.searchModel.getSearchItems(

(s) => s.type === "favorite"

);

const favorites = searchItems.filter(

(f) => f.description === this.state.description

);

var searchItems = this.env.searchModel.getSearchItems(

(s) => s.type === "favorite" && s.description === this.state.description

);

(there are a few similar simplifications that could be made around the code)

Modified as suggested. Identified in few other places and modified it. However, could not modify in places like here and popover is not visible when modifying it.

HekkiMelody · 2024-12-03T14:09:34Z

Unverified Scenarios:

In unpack_filter function, there is a branch deals with tentative filter/groupBy which could not be verified as not able to understand the feature from README file or in general.
So, I would like to know how this scenario could be verified? Any suggestions would be helpful to verify it.

From testing on v14, tentativeFilter (here and here) is used when customized filters are used via the "Add custom filter" and "Add custom group" buttons. That's when the pre-defined filter cannot be found. In that case, the module tries to compensate for it and find a similar filter, but it doesn't seem to me like it works very well at all (in v14).

In fact, in v14, contacts view:

Group by Country
Add Custom Group -> City (not in the pre-defined group-by options)
Save as favourite, and reload the page
Apply the filter, and then click on the pencil to edit it
ISSUE: The filter is taken apart but only the Country groupby remains, instead of having the two nested filters like before.

I'd even go as far as suggesting removing that code path entirely, and adding to the Roadmap that the module is not currently compatible with custom filters. I don't think it's within the scope of the migration to fix that problem, necessarily.

Though of course the last word is up to a maintainer.

anusriNPS · 2024-12-04T12:06:30Z

Tried to use custom groups and filters as mentioned and it works in v16 and it is able to unpack the filters/groupBy which are selected from Add custom filter/group

For eg: (Both "Application" and "Created By" custom groups under App module)

Click on "Add Custom Group -> "Application"
Click on "Add Custom Group -> "Created By"
Save as favorite.
Click on favorite facet and then clicking on pencil icon, it unpacks selected custom groups.

However, for this case as well it did not go inside tentative filter related branch code, so removed for now from the PR.

In order to include as part of ROADMAP, I am not sure what to be mentioned as above custom related filters/groupBy works in v16(though it does not work in v14).

As part of latest patchset, corrected issue with displaying facet values and unpacking facets that related to type "field".

HekkiMelody · 2024-12-04T16:05:13Z

Tried to use custom groups and filters as mentioned and it works in v16 and it is able to unpack the filters/groupBy which are selected from Add custom filter/group

For eg: (Both "Application" and "Created By" custom groups under App module)
1. Click on "Add Custom Group -> "Application"

2. Click on "Add Custom Group -> "Created By"

3. Save as favorite.

4. Click on favorite facet and then clicking on pencil icon, it unpacks selected custom groups.
However, for this case as well it did not go inside tentative filter related branch code, so removed for now from the PR.

In order to include as part of ROADMAP, I am not sure what to be mentioned as above custom related filters/groupBy works in v16(though it does not work in v14).

As part of latest patchset, corrected issue with displaying facet values and unpacking facets that related to type "field".

I had not tested on v16, if it works correctly then great, no need to mention anything on the roadmap. Thank you

HekkiMelody

Code review, LGTM, just some minor non-blocking code cleanup possible

HekkiMelody · 2024-12-04T16:10:50Z

web_edit_user_filter/static/src/js/searchBar.esm.js

+            var currentFacet = this.env.searchModel.getSearchItems(
+                (f) => f.type === facet_type && f.groupId == facetId
+            );


comment (non-blocking): I think in this case using searchItems.filter was better, because you're filtering a subset of the searchItems you had already filtered beforehand, instead of searching from every filter in the model.

On the other hand, if searchItems is already filtered by facet_type and you use .filter here, you can drop the f.type === facet_type condition because it was already checked earlier.

Updated as suggested

anusriNPS · 2024-12-06T09:56:40Z

Identified an item for ROADMAP and included it on the ROADMAP file.

AnizR

Code LGTM and it works as described.

Thanks!

SAnnabelle

There is an error on the filters that already existed before the module was installed.

UncaughtClientError > SyntaxError Erreur Javascript non interceptée > "undefined" is not valid JSON SyntaxError: "undefined" is not valid JSON at JSON.parse (<anonymous>) at SearchBar._unpackFilter (https://odoo/web/assets/1941417-e5f98c9/web.assets_backend.min.js:18312:577) at HTMLAnchorElement.<anonymous> (https://odoo/web/assets/1941417-e5f98c9/web.assets_backend.min.js:18311:822) at HTMLAnchorElement.dispatch (https://odoo/web/assets/1941416-2c43b8a/web.assets_common.min.js:2469:447) at elemData.handle (https://odoo/web/assets/1941416-2c43b8a/web.assets_common.min.js:2455:166)

AnizR · 2025-05-20T09:52:27Z

web_edit_user_filter/static/src/js/searchBar.esm.js

+        );
+
+        var selectedFacet = searchItems.filter(
+            (f) => f.groupId == facetId && f.isActive === true


Suggested change

(f) => f.groupId == facetId && f.isActive === true

(f) => f.groupId == facetId && f.isActive === true && (f.type !== 'favorite' || f.facet !== undefined)

I would recommend adding this.
Otherwise, as @SAnnabelle pointed out, we will have an error when editing a favorite filter that was created before installing this module.

I agree to implement the suggestion, but when I tried to reproduce the issue locally, it could not reproduce it.

I tried editing favorites thinking latest code base would introduced such errors, but while testing on latest code base I could not reproduce it.

@SAnnabelle , could you please let me know how can I reproduce it? So, I can push the required changes.

To reproduce the error, I did this:

Create a favorite filter

Install the module 'web_edit_user_filter'

Try to edit the favorite filter that I created

Error is thrown

The problem is that facet wasn't set when creating my filter since the module wasn't yet installed.

Thank you for detailed response. I am able to reproduce it. With provided suggestion, user won't be able to see edit button for favorites whose facet is not available.

I have commented reason for the condition added. Should we notify the user that it can't be unpacked?

Well, not displaying the edit button is enough IMO

[FIX] Readme [FIX] Lint [ADD] Tests [IMP] UI/UX [IMP] Hide popover when other is opened [IMP] Add item to roadmap

Added translation using Weblate (Chinese (Simplified)) Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (3 of 3 strings) Translation: web-12.0/web-12.0-web_edit_user_filter Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_edit_user_filter/zh_CN/ Added translation using Weblate (Croatian) Translated using Weblate (Croatian) Currently translated at 66.7% (2 of 3 strings) Translation: web-12.0/web-12.0-web_edit_user_filter Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_edit_user_filter/hr/ Added translation using Weblate (Portuguese) Translated using Weblate (Portuguese) Currently translated at 100.0% (3 of 3 strings) Translation: web-12.0/web-12.0-web_edit_user_filter Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_edit_user_filter/pt/

has to explicit check for type of value !== null as the typeof null is object https://i.stack.imgur.com/FzI1R.png

Added translation using Weblate (Danish) Translated using Weblate (Danish) Currently translated at 100.0% (3 of 3 strings) Translation: web-12.0/web-12.0-web_edit_user_filter Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_edit_user_filter/da/

Added translation using Weblate (Spanish) Translated using Weblate (Spanish) Currently translated at 100.0% (3 of 3 strings) Translation: web-12.0/web-12.0-web_edit_user_filter Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_edit_user_filter/es/ Added translation using Weblate (French) Translated using Weblate (French) Currently translated at 100.0% (3 of 3 strings) Translation: web-12.0/web-12.0-web_edit_user_filter Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_edit_user_filter/fr/ Added translation using Weblate (Catalan) Translated using Weblate (Catalan) Currently translated at 100.0% (3 of 3 strings) Translation: web-12.0/web-12.0-web_edit_user_filter Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_edit_user_filter/ca/

Added translation using Weblate (Portuguese (Brazil)) Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (3 of 3 strings) Translation: web-12.0/web-12.0-web_edit_user_filter Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_edit_user_filter/pt_BR/

When clicking to edit a filter in search view, the _process_filters function will receive the faceID argument as a string, which will be compared to facet.groupId that is an Integer. Therefore we should use == operator when comparing this value to allow type coercion from JS.

anusriNPS · 2025-07-04T14:44:40Z

Updated commit to handle error seen below when clicked on "Add to My Dashboard" under "Favorites"

UncaughtPromiseError > TypeError
Uncaught Promise > right-hand side of 'in' should be an object, got undefined
TypeError: right-hand side of 'in' should be an object, got undefined
_getIrFilterDescription@http://localhost:16069/web/assets/56995-84bd7fb/web.assets_backend.min.js:16716:372
_getIrFilterDescription (patch web_edit_user_filter.SearchModel)@http://localhost:16069/web/assets/56995-84bd7fb/web.assets_backend.min.js:1691:22
getPreFavoriteValues@http://localhost:16069/web/assets/56995-84bd7fb/web.assets_backend.min.js:2103:54
addToBoard@http://localhost:16069/web/assets/56995-84bd7fb/web.assets_backend.min.js:15430:122
mainEventHandler@http://localhost:16069/web/assets/56988-fc17d32/web.assets_common.min.js:2139:77
listener@http://localhost:16069/web/assets/56988-fc17d32/web.assets_common.min.js:1294:15

OCA-git-bot · 2025-07-04T15:00:01Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

ivs-cetmix · 2025-12-22T13:29:45Z

Hey @anusriNPS thank you for your contribution! @SAnnabelle could you please check again if everything works as expected?

anusriNPS marked this pull request as draft December 2, 2024 08:12

anusriNPS force-pushed the 16.0-mig-web_edit_user_filter branch 7 times, most recently from bb1ccf2 to 8643376 Compare December 3, 2024 10:13

anusriNPS marked this pull request as ready for review December 3, 2024 10:23

HekkiMelody reviewed Dec 3, 2024

View reviewed changes

anusriNPS force-pushed the 16.0-mig-web_edit_user_filter branch from 8643376 to f01d632 Compare December 4, 2024 11:53

HekkiMelody approved these changes Dec 4, 2024

View reviewed changes

anusriNPS force-pushed the 16.0-mig-web_edit_user_filter branch from f01d632 to 9b842b6 Compare December 6, 2024 09:54

HekkiMelody approved these changes Dec 6, 2024

View reviewed changes

anusriNPS mentioned this pull request Apr 14, 2025

Migration to version 16.0 #2309

Open

47 tasks

AnizR approved these changes May 14, 2025

View reviewed changes

OCA-git-bot added the approved label May 14, 2025

SAnnabelle reviewed May 16, 2025

View reviewed changes

AnizR suggested changes May 20, 2025

View reviewed changes

OCA-git-bot removed the approved label May 20, 2025

anusriNPS force-pushed the 16.0-mig-web_edit_user_filter branch 2 times, most recently from 9bcc8da to 465ba8e Compare May 27, 2025 08:21

AnizR approved these changes May 27, 2025

View reviewed changes

OCA-git-bot added the approved label May 27, 2025

[ADD] web_edit_user_filter

5f2de75

[FIX] Readme [FIX] Lint [ADD] Tests [IMP] UI/UX [IMP] Hide popover when other is opened [IMP] Add item to roadmap

OCA-git-bot and others added 14 commits July 4, 2025 16:33

[UPD] README.rst

ccb29f4

has to explicit check for type of value !== null

d8ce7c9

has to explicit check for type of value !== null as the typeof null is object https://i.stack.imgur.com/FzI1R.png

web_edit_user_filter 12.0.1.0.2

e2a2423

[IMP] web_edit_user_filter: black, isort, prettier

5f80cc7

[MIG] web_edit_user_filter: Migration to 14.0

8f82080

[UPD] Update web_edit_user_filter.pot

4636386

[BOT] post-merge updates

d7eec39

[MIG] web_edit_user_filter: Migration to 15.0

a317499

[MIG] web_edit_user_filter: Migration to 16.0

84fc6ee

anusriNPS force-pushed the 16.0-mig-web_edit_user_filter branch from 465ba8e to 84fc6ee Compare July 4, 2025 14:35

OCA-git-bot added the ready to merge label Jul 4, 2025

		"web_edit_user_filter/static/src/xml/backend.xml",
		"web_edit_user_filter/static/src/xml/search_extended.xml",

	"web_edit_user_filter/static/src/xml/backend.xml",
	"web_edit_user_filter/static/src/xml/search_extended.xml",
	"web_edit_user_filter/static/src/xml/*.xml",

	(f) => f.groupId == facetId && f.isActive === true
	(f) => f.groupId == facetId && f.isActive === true && (f.type !== 'favorite' \|\| f.facet !== undefined)

Uh oh!

[16.0][MIG]: web_edit_user_filter: Migration to 16.0 #3007

Are you sure you want to change the base?

[16.0][MIG]: web_edit_user_filter: Migration to 16.0 #3007

Uh oh!

Conversation

anusriNPS commented Dec 2, 2024

Uh oh!

anusriNPS commented Dec 3, 2024

Verified Scenarios:

Unverified Scenarios:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HekkiMelody commented Dec 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unverified Scenarios:

Uh oh!

anusriNPS commented Dec 4, 2024

Uh oh!

HekkiMelody commented Dec 4, 2024

Uh oh!

HekkiMelody left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anusriNPS commented Dec 6, 2024

Uh oh!

AnizR left a comment

Choose a reason for hiding this comment

Uh oh!

SAnnabelle left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AnizR May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anusriNPS commented Jul 4, 2025

Uh oh!

OCA-git-bot commented Jul 4, 2025

Uh oh!

ivs-cetmix commented Dec 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

HekkiMelody commented Dec 3, 2024 •

edited

Loading

AnizR May 27, 2025 •

edited

Loading