[16.0][ADD] web_sort_menu: Module web_sort_menu #3199

anusriNPS · 2025-06-17T10:02:43Z

Module web_sort_menu is introduced to sort apps in alphabetical order while displayed on NavBar

anusriNPS · 2025-06-17T12:22:07Z

SirPyTech

Thanks for the PR!
It is a very clean approach, please see the comments below.

SirPyTech · 2025-06-18T07:43:28Z

web_sort_menu/static/src/xml/sort_app_menu.xml

+        t-inherit-mode="extension"
+        owl="1"
+    >
+         <xpath expr="//header[@class='o_navbar']//t/t" position="replace">


suggestion: Please use a more focused xpath: if you want to find the element that has t-set="apps", then you can use t[@t-set='apps'] in the xpath.
Searching for //t/t is difficult to maintain because it is not clear which node you are looking for.

Thank you for the input. Updated as suggested.

SirPyTech · 2025-06-18T07:44:00Z

web_sort_menu/static/src/xml/sort_app_menu.xml

+        t-inherit-mode="extension"
+        owl="1"
+    >
+         <xpath expr="//header[@class='o_navbar']//t/t" position="replace">


suggestion: replace is risky because other modules might expect that node to be present, so it should be avoided as much as possible.
In this case I suggest to go after the node that sets the apps variable and substitute its value with the sorted list.

Updated using "attributes"

SirPyTech · 2025-06-18T07:46:11Z

web_sort_menu/__manifest__.py

+    "author": "Anusri Veerappan Prakasam, Odoo Community Association (OCA)",
+    "website": "https://github.com/OCA/web",
+    "license": "AGPL-3",
+    "depends": ["web", "web_responsive"],


suggestion

Suggested change

"depends": ["web", "web_responsive"],

"depends": ["web",],

I can't find where the dependency from web_responsive is needed, could you please check if that's actually necessary?
Without web_responsive, I expect that the dropdown menu is sorted.

I missed to think about dropdown menu getting sorted, I thought only NavBar would be sorted hence added web_responsive in the dependency.

I see dropdown menu getting sorted, hence removed web_responsive module as dependency.

SirPyTech · 2025-06-18T07:48:13Z

web_sort_menu/static/src/js/sort_app_menu.esm.js

+
+        onWillStart(() => {
+            const apps = this.menuService.getApps();
+            this.sortedApps = apps.sort((a, b) => a.name.localeCompare(b.name));


note: It is worth noting that apps are sorted based on the translated name, so users with different languages will see them in a different order

Yes, based on different languages sorting happens according to it.

Updated Description of module with this information.

praise: Thanks for updating the documentation, this is something that developers rarely do in response to this kind of comments.
👍

SirPyTech · 2025-06-18T07:56:40Z

web_sort_menu/static/src/js/sort_app_menu.esm.js

+        this.sortedApps = [];
+
+        onWillStart(() => {
+            const apps = this.menuService.getApps();


thought: I don't think this search is that expensive, but we could avoid it by sorting directly in the template, or exposing a method and calling it in the template.
This would also preserve any edit that other modules have done to the apps variable in the template.

I agree with you that we preseve any other module editing the value of apps,.

I tried to implement this search explicitly in the sort menu. However, I see we would need to use menuService in order to get information about available apps to sort them. If so, we could directly use the function exposed in menuService to know apps information.

Please let me know your views on it.

I meant that you could create a new method in this patched class like

sortApps((apps) => { return apps.sort((a, b) => a.name.localeCompare(b.name)); }),

and then in the template just add a call to this method:

<xpath expr="<select the t-set="apps" node>" position="after"> <t t-set="apps" t-value="sortApps(apps)"/> </xpath>

since the method is really simple, everything could be in the template too, but I think it's better to keep the code where code should be (JS in this case) and let the templates handle only the rendering as much as possible.

SirPyTech · 2025-06-18T08:05:33Z

web_sort_menu/static/src/xml/sort_app_menu.xml

+        t-inherit-mode="extension"
+        owl="1"
+    >
+         <xpath expr="//header[@class='o_navbar']//t/t" position="replace">


issue: The usage of @class is discouraged (see odoo/odoo@cbffd99), please use hasclass instead.

Updated using hasclass

SirPyTech

Code and functional review, looks good to me.

I have just added an example for the improvement I suggested in #3199 (comment), but it's already good for merge in my opinion.

SirPyTech · 2025-06-20T09:26:52Z

web_sort_menu/static/src/js/sort_app_menu.esm.js

+
+        onWillStart(() => {
+            const apps = this.menuService.getApps();
+            this.sortedApps = apps.sort((a, b) => a.name.localeCompare(b.name));


praise: Thanks for updating the documentation, this is something that developers rarely do in response to this kind of comments.
👍

SirPyTech · 2025-06-20T09:33:22Z

web_sort_menu/static/src/js/sort_app_menu.esm.js

+        this.sortedApps = [];
+
+        onWillStart(() => {
+            const apps = this.menuService.getApps();


I meant that you could create a new method in this patched class like

sortApps((apps) => { return apps.sort((a, b) => a.name.localeCompare(b.name)); }),

and then in the template just add a call to this method:

<xpath expr="<select the t-set="apps" node>" position="after"> <t t-set="apps" t-value="sortApps(apps)"/> </xpath>

since the method is really simple, everything could be in the template too, but I think it's better to keep the code where code should be (JS in this case) and let the templates handle only the rendering as much as possible.

SirPyTech · 2025-06-20T09:35:46Z

web_sort_menu/static/src/xml/sort_app_menu.xml

+        t-inherit-mode="extension"
+        owl="1"
+    >
+         <xpath expr="//header[@class='o_navbar']//t/t" position="replace">


SirPyTech · 2025-06-20T09:35:54Z

web_sort_menu/static/src/xml/sort_app_menu.xml

+        t-inherit-mode="extension"
+        owl="1"
+    >
+         <xpath expr="//header[@class='o_navbar']//t/t" position="replace">


SirPyTech · 2025-06-20T09:36:11Z

web_sort_menu/__manifest__.py

+    "author": "Anusri Veerappan Prakasam, Odoo Community Association (OCA)",
+    "website": "https://github.com/OCA/web",
+    "license": "AGPL-3",
+    "depends": ["web", "web_responsive"],


SirPyTech · 2025-06-20T09:38:39Z

web_sort_menu/static/src/xml/sort_app_menu.xml

+        t-inherit-mode="extension"
+        owl="1"
+    >
+         <xpath expr="//header[@class='o_navbar']//t/t" position="replace">


anusriNPS · 2025-06-20T13:44:43Z

Suggestion was super good and precise, so implemented the same.

OCA-git-bot · 2025-06-25T13:32:07Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

andreampiovesana

LGTM, merge?

ivs-cetmix

Hey @anusriNPS thank you for your contribution! Some small change and LGTM 😉

ivs-cetmix · 2025-12-22T13:33:26Z

web_sort_menu/static/description/icon.png

Please remove this icon, it will be added automatically on merge. Or use the actually one from

Removed the icon as suggested.

ivs-cetmix · 2025-12-22T13:43:47Z

@anusriNPS thank you for prompt action 😉
/ocabot merge nobump

OCA-git-bot · 2025-12-22T13:43:54Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-3199-by-ivs-cetmix-bump-nobump, awaiting test results.

OCA-git-bot · 2025-12-22T13:52:38Z

Congratulations, your PR was merged at 7640f2a. Thanks a lot for contributing to OCA. ❤️

anusriNPS force-pushed the 16.0-web_sort_menu branch 2 times, most recently from a4867e9 to aad2db6 Compare June 17, 2025 10:31

SirPyTech suggested changes Jun 18, 2025

View reviewed changes

anusriNPS force-pushed the 16.0-web_sort_menu branch from aad2db6 to 17e20fa Compare June 18, 2025 09:02

SirPyTech approved these changes Jun 20, 2025

View reviewed changes

anusriNPS force-pushed the 16.0-web_sort_menu branch from 17e20fa to bfcd7ce Compare June 20, 2025 13:39

SirPyTech approved these changes Jun 24, 2025

View reviewed changes

aleuffre approved these changes Jun 25, 2025

View reviewed changes

OCA-git-bot added approved ready to merge labels Jun 25, 2025

anusriNPS force-pushed the 16.0-web_sort_menu branch from bfcd7ce to 04f459d Compare September 12, 2025 09:30

andreampiovesana approved these changes Dec 9, 2025

View reviewed changes

ivs-cetmix requested changes Dec 22, 2025

View reviewed changes

OCA-git-bot removed approved ready to merge labels Dec 22, 2025

[16.0][ADD] web_sort_menu: Module web_sort_menu

8a7c0d3

anusriNPS force-pushed the 16.0-web_sort_menu branch from 04f459d to 8a7c0d3 Compare December 22, 2025 13:39

OCA-git-bot added the bot is merging ⏳ label Dec 22, 2025

OCA-git-bot merged commit 43fde86 into OCA:16.0 Dec 22, 2025
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Dec 22, 2025

ivs-cetmix mentioned this pull request Dec 22, 2025

[18.0][MIG] web_sort_menu: Migration to 18.0 #3345

Open

aleuffre deleted the 16.0-web_sort_menu branch December 22, 2025 16:34

Uh oh!

[16.0][ADD] web_sort_menu: Module web_sort_menu #3199

[16.0][ADD] web_sort_menu: Module web_sort_menu #3199

Uh oh!

Conversation

anusriNPS commented Jun 17, 2025

Uh oh!

anusriNPS commented Jun 17, 2025

Uh oh!

SirPyTech left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SirPyTech left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anusriNPS commented Jun 20, 2025

Uh oh!

OCA-git-bot commented Jun 25, 2025

Uh oh!

andreampiovesana left a comment

Choose a reason for hiding this comment

Uh oh!

ivs-cetmix left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ivs-cetmix commented Dec 22, 2025

Uh oh!

OCA-git-bot commented Dec 22, 2025