-
-
Notifications
You must be signed in to change notification settings - Fork 2k
[18.0][IMP] web_theme_classic Add ability to toggle theme #3394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
|
Hi @legalsylvain, |
|
Closes #3234 |
6122b17 to
a9eb091
Compare
legalsylvain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feature looks disabled by défaut. Or did i missed something ?
| class ResUsers(models.Model): | ||
| _inherit = "res.users" | ||
|
|
||
| persistent_classic_theme = fields.Boolean( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| persistent_classic_theme = fields.Boolean( | |
| persistent_classic_theme = fields.Boolean( | |
| défaut=True, |
|
@legalsylvain yes, I left the persistent option disabled by default so that the toggle on the user menu would be visible and individual users can make a choice whether to turn it on or not, and what mode to use. |
Well, If someone install this module, he hopes that the feature will be enabled by default. Otherwise, it forces each user to enable it manually. So, yes, please put the value enabled by default. If user want to disable it, he can. |
|
@legalsylvain Yes, I see what you mean. I will change it |
Now you can either enable by user with Classic Theme Persistent setting, or toggle it on and off like tark mode. It uses a cookie to remember your preference between reloads.
a9eb091 to
993fb6c
Compare
|
@legalsylvain All set! |
legalsylvain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks !
Now you can either enable by user with Classic Theme Persistent setting, or toggle it on and off like dark mode. It uses a cookie to remember your preference between reloads.
Screenshots
Toggle Hidden because Classic Theme Persistent turned on