Thanks to visit codestin.com
Credit goes to Github.com

Skip to content

Conversation

@ljmnoonan
Copy link
Contributor

Now you can either enable by user with Classic Theme Persistent setting, or toggle it on and off like dark mode. It uses a cookie to remember your preference between reloads.

Screenshots image image image

Toggle Hidden because Classic Theme Persistent turned on

image

@OCA-git-bot
Copy link
Contributor

Hi @legalsylvain,
some modules you are maintaining are being modified, check this out!

@ljmnoonan
Copy link
Contributor Author

Closes #3234

@ljmnoonan ljmnoonan force-pushed the 18.0-web_theme_classic branch from 6122b17 to a9eb091 Compare December 16, 2025 00:41
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature looks disabled by défaut. Or did i missed something ?

class ResUsers(models.Model):
_inherit = "res.users"

persistent_classic_theme = fields.Boolean(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
persistent_classic_theme = fields.Boolean(
persistent_classic_theme = fields.Boolean(
défaut=True,

@ljmnoonan
Copy link
Contributor Author

@legalsylvain yes, I left the persistent option disabled by default so that the toggle on the user menu would be visible and individual users can make a choice whether to turn it on or not, and what mode to use.
I can change it though if you think it makes more sense to enable persistent mode for all users at install by default

@legalsylvain
Copy link
Contributor

@legalsylvain yes, I left the persistent option disabled by default so that the toggle on the user menu would be visible and individual users can make a choice whether to turn it on or not, and what mode to use.

Well, If someone install this module, he hopes that the feature will be enabled by default. Otherwise, it forces each user to enable it manually. So, yes, please put the value enabled by default. If user want to disable it, he can.
Don't you think ?

@ljmnoonan
Copy link
Contributor Author

@legalsylvain Yes, I see what you mean. I will change it

Now you can either enable by user with Classic Theme Persistent setting,
or toggle it on and off like tark mode. It uses a cookie to remember your
preference between reloads.
@ljmnoonan ljmnoonan force-pushed the 18.0-web_theme_classic branch from a9eb091 to 993fb6c Compare December 16, 2025 12:23
@ljmnoonan
Copy link
Contributor Author

@legalsylvain All set!

Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants