[16.0][FIX] web_group_by_percentage: Added exclusion of non-field columns #3397
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some list/tree views, there are non-field columns, for instance buttons to handle an action on a group of lines. Consequently, with this module installed, it's impossible to group lines in certain views, if the grouped view has a button, as using isNumericColumn, which tries to access the column in the view's fields, throws an Exception. As such, we exclude non-field columns from the computation of grouped columns percentages.
fcayre
approved these changes
Dec 16, 2025
Member
fcayre
left a comment
There was a problem hiding this comment.
Code review + functional test OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some list/tree views, there are non-field columns, for instance buttons to handle an action on a group of lines. Consequently, with this module installed, it's impossible to group lines in certain views, if the grouped view has a button, as using isNumericColumn, which tries to access the column in the view's fields, throws an Exception.
As such, we exclude non-field columns from the computation of grouped columns percentages.