[16.0][FIX] shopfloor_base: fix _registered_endpoint_rule_keys#1136
Open
nicolas-delbovier-acsone wants to merge 2 commits intoOCA:16.0from
Open
[16.0][FIX] shopfloor_base: fix _registered_endpoint_rule_keys#1136nicolas-delbovier-acsone wants to merge 2 commits intoOCA:16.0from
nicolas-delbovier-acsone wants to merge 2 commits intoOCA:16.0from
Conversation
Contributor
This was breaking _unregister_controllers since we don't get tuples
but EndpointRule objects.
Prior to this change the call failed like
File /odoo/external-src/shopfloor-app/shopfloor_base/models/shopfloor_app.py, line 166, in _registered_endpoint_rule_keys
return [x[0] for x in self._registered_routes()]
~^^^
TypeError: 'EndpointRule' object is not subscriptable
* ensure manifest url is always the same * improve comparison on handler options
6a4a6d0 to
eb1d63e
Compare
lmignon
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a partial backport of OCA/shopfloor-app#19, following up on the discussion in #1104.
Improvements & Fixes
shopfloor_base: fix
_registered_endpoint_rule_keysCorrects a TypeError where EndpointRule objects were being accessed as tuples (non-subscriptable).
This ensures that archiving an app and syncing the registry no longer triggers a crash.
Exclusions & Technical Notes
Routing Registration Fix
I have intentionally excluded the "routing registration" fix from this backport for the following reasons:
Wrong value for endpoint.route.handler.tool.route_type: 'restapi'