[19.0][MIG] crm_claim: migration to 19.0#713
Open
Vicent-S73 wants to merge 47 commits intoOCA:19.0from
Open
Conversation
4f94551 to
f7e417b
Compare
rrebollo
suggested changes
Dec 28, 2025
rrebollo
left a comment
There was a problem hiding this comment.
Code Review: Great work! The code looks good to me (LGTM). Thank you for your contribution! I've provided a few suggestions, some I think mandatory, most for your consideration—feel free to address them as you see fit.
|
@Vicent-S73 also, would you be so kind to review my PR #661? |
Include record rule for multi-company.
The Claim form's statusbar is intended to be clickable, but Odoo 13 is
apparently no longer compatible with `clickable="True"`. Instead, either
`clickable="1"` or `options="{'clickable': 1}"` must be used. Odoo core
code uses the latter, so the Claim form has been updated to match core
convention.
crm_claim 13.0.1.0.1
crm_claim 14.0.1.0.1
Currently translated at 100.0% (144 of 144 strings) Translation: crm-14.0/crm-14.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-14-0/crm-14-0-crm_claim/de/
We didn't have activities back in v8 but the fields `action_next` and `date_deadline` in the models to be set from the views. In the later migration to v11 those view fields were adapted to the proper similar ones in activities. But that's useless, as activities have their own UI ready to be used from any model with the mixin. TT38822 crm_claim 15.0.1.1.0
Currently translated at 100.0% (147 of 147 strings) Translation: crm-15.0/crm-15.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_claim/es/
Currently translated at 100.0% (147 of 147 strings) Translation: crm-15.0/crm-15.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_claim/ca/
Translated using Weblate (Italian) Currently translated at 100.0% (143 of 143 strings) Translation: crm-16.0/crm-16.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_claim/it/
Currently translated at 100.0% (143 of 143 strings) Translation: crm-16.0/crm-16.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_claim/es/
Currently translated at 100.0% (143 of 143 strings) Translation: crm-16.0/crm-16.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_claim/es/
Currently translated at 91.5% (130 of 142 strings) Translation: crm-16.0/crm-16.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_claim/fr_FR/
It's setting a context when creating records for the default team_id and it's not necessary, it's redundant because the team_id field already has a default that defines it. This code is not necessary. TT49102
…to claim form view TT46565
Currently translated at 16.1% (23 of 142 strings) Translation: crm-16.0/crm-16.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_claim/pt_BR/
[UPD] Update crm_claim.pot [BOT] post-merge updates
[BOT] post-merge updates
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: crm-18.0/crm-18.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-18-0/crm-18-0-crm_claim/
Currently translated at 100.0% (140 of 140 strings) Translation: crm-18.0/crm-18.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-18-0/crm-18-0-crm_claim/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: crm-18.0/crm-18.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-18-0/crm-18-0-crm_claim/
8d6eb5f to
7b8c323
Compare
7b8c323 to
b34bd41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.