[18.0][FIX] fetchmail_attach_from_folder: add missing keyword argument #3460
+23
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @NL66278, |
ec9038b to
add41cf
Compare
NL66278
reviewed
Dec 21, 2025
| return result | ||
|
|
||
| def fetch_mail(self): | ||
| def fetch_mail(self, raise_exception=True): |
Contributor
There was a problem hiding this comment.
instead of raise_exception=True put **kwargs here.
NL66278
reviewed
Dec 21, 2025
| for this in self: | ||
| if not this.folders_only: | ||
| result = result and super(FetchmailServer, this).fetch_mail() | ||
| result = result and super(FetchmailServer, this).fetch_mail( |
Contributor
There was a problem hiding this comment.
and **kwargs here. We are not doing anything with any keyword argument here, so using '**kwargs` will pass any keyword argument in the invocation of this method unchanged to the super() method. This will keep working, no matter how many keyword arguments are added or changed in the future.
NL66278
suggested changes
Dec 21, 2025
Contributor
NL66278
left a comment
There was a problem hiding this comment.
See comment on using **kwargs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When manually running mail.ir_cron_mail_gateway_action "https://github.com/odoo/odoo/blob/18.0/addons/mail/data/ir_cron_data.xml" , the following error occurs because the base function has the argument set. "https://github.com/odoo/odoo/blob/18.0/addons/mail/models/fetchmail.py"
Error:
