Add reactive properties, command palette, and scrollback/copy mode#7
Merged
Add reactive properties, command palette, and scrollback/copy mode#7
Conversation
Implements three advanced Textual features for txtmux: 1. Reactive Properties: - Replaced manual self.refresh() calls with reactive property - terminal_buffer_version auto-triggers UI updates - Lines 215, 253, 372 in terminal_widget.py 2. Command Palette: - Enabled Ctrl+P command palette - Added SessionCommandProvider for session switching - Fuzzy search across sessions 3. Scrollback/Copy Mode: - Switched from pyte.Screen to pyte.HistoryScreen (10k lines) - Created modal CopyModeScreen with vi-style navigation - Keybinding: Ctrl+B then PageUp or [ to enter - Copy with 'y', scroll with g/G/j/k, exit with q/Escape Closes #3 Co-authored-by: OhadRubin <[email protected]>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
- Change key binding from "[" to "left_square_bracket" for Textual - Fix pyte history access: use screen.history.top instead of screen.history - Add virtualized scrollback widget for performance - Limit history to 1000 lines - Remove unused import Note: Copy mode has remaining rendering issues to be fixed in future PR. Co-Authored-By: Claude Opus 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements three advanced Textual features for txtmux:
Closes #3
Generated with Claude Code