Thanks to visit codestin.com
Credit goes to Github.com

Skip to content

Comments

Improve StatusBar, eliminate hardcoded dimensions, add tab state indicators#9

Open
OhadRubin wants to merge 1 commit intomasterfrom
claude/issue-4-20260113-0940
Open

Improve StatusBar, eliminate hardcoded dimensions, add tab state indicators#9
OhadRubin wants to merge 1 commit intomasterfrom
claude/issue-4-20260113-0940

Conversation

@OhadRubin
Copy link
Owner

@OhadRubin OhadRubin commented Jan 13, 2026

Implements three interconnected UI improvements to txtmux:

Phase 1: Constants Module

Created constants.py with DEFAULT_TERMINAL_WIDTH and DEFAULT_TERMINAL_HEIGHT, eliminating 7 hardcoded 80x24 references.

Phase 2: Enhanced StatusBar

Replaced basic StatusBar with EnhancedStatusBar using reactive properties for automatic UI updates. Shows session ID and connection state.

Phase 3: Tab State Indicators

Added visual state indicators to SessionTabs with methods for marking activity and connection status.

These changes improve code maintainability, user experience, and follow Textual best practices.

Fixes #4

Generated with Claude Code

@github-actions @OhadRubin
Improve StatusBar, eliminate hardcoded dimensions, add tab state indi…
553afd0 
…cators

This commit implements three interconnected UI improvements:

1. **Constants Module (Phase 1)**:
   - Created constants.py with DEFAULT_TERMINAL_WIDTH and DEFAULT_TERMINAL_HEIGHT
   - Updated all 7 hardcoded 80x24 references across client.py and terminal_widget.py
   - Follows DRY principle and makes future changes easier

2. **Enhanced StatusBar (Phase 2)**:
   - Replaced basic StatusBar with EnhancedStatusBar using reactive properties
   - Added reactive properties: session_name, session_id, connected
   - Automatic UI updates via watch methods
   - Displays session ID alongside session name
   - Shows connection state with visual indicator
   - Updated CSS styling for status bar states

3. **Tab State Indicators (Phase 3)**:
   - Added reactive state tracking to SessionTabs widget
   - Implemented methods: mark_activity(), clear_activity(), mark_disconnected(), mark_connected()
   - Added CSS classes for visual states: .has-activity and .disconnected
   - Activity indicator automatically clears when switching to a tab
   - State initialization for new sessions

These changes improve code maintainability (constants), user experience
(status indicators), and follow Textual best practices (reactive properties,
CSS classes for state management).

Fixes #4

Co-authored-by: OhadRubin <[email protected]>
@claude
Copy link

claude bot commented Jan 13, 2026

Code Review

This PR introduces well-structured improvements to the UI with clean code changes. However, the CLAUDE.md documentation needs to be updated to reflect the changes made in this PR.

Issues Found

1. Missing constants.py in Project Structure Documentation

The PR introduces a new file src/txtmux/constants.py that centralizes terminal dimension constants, but this file is not documented in the Project Structure section of CLAUDE.md.

Current Project Structure (CLAUDE.md lines 12-19):

src/txtmux/          # Main package
  cli.py             # CLI entry point
  client.py          # Textual TUI app
  server.py          # Daemon server
  session.py         # Session/Pane management
  protocol.py        # Binary protocol
  pty_handler.py     # PTY operations
  terminal_widget.py # Terminal widget

Suggested fix: Add constants.py to the list:

 src/txtmux/          # Main package
   cli.py             # CLI entry point
   client.py          # Textual TUI app
+  constants.py       # Terminal dimension constants
   server.py          # Daemon server
   session.py         # Session/Pane management
   protocol.py        # Binary protocol
   pty_handler.py     # PTY operations
   terminal_widget.py # Terminal widget

Reason: CLAUDE.md serves as guidance for working with the codebase. Since constants.py is a new module file imported by multiple components (client.py and terminal_widget.py), it should be documented alongside other module files.

2. Outdated StatusBar Reference in Architecture Documentation

The PR renames StatusBar to EnhancedStatusBar in client.py, but the Architecture section of CLAUDE.md still references the old class name.

Current Architecture diagram (CLAUDE.md line 67):

│ client.py (Textual App)                                         │
│  - TerminalApp: Header + TerminalPane + StatusBar               │
│  - Ctrl+B D prefix handling for detach                          │

Suggested fix:

 │ client.py (Textual App)                                         │
-│  - TerminalApp: Header + TerminalPane + StatusBar               │
+│  - TerminalApp: Header + TerminalPane + EnhancedStatusBar       │
 │  - Ctrl+B D prefix handling for detach                          │

Reason: The Architecture section documents specific component class names (not just conceptual abstractions). Since the status bar component has been renamed to EnhancedStatusBar, the documentation should reflect this change to maintain accuracy.

Summary

Code quality: ✅ No bugs or logic errors found
CLAUDE.md compliance: ⚠️ 2 documentation updates needed

The code changes themselves are well-implemented with proper use of Textual's reactive properties and good refactoring practices. The only issues are documentation updates needed in CLAUDE.md to keep it synchronized with the codebase changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve StatusBar, Eliminate Hardcoded Dimensions, Add Tab State Indicators

1 participant

@OhadRubin