Add official variable to chapters and check for changes to official status#557
Add official variable to chapters and check for changes to official status#557TheyCallMeTravis wants to merge 13 commits intoC9Glax:cuttingedgefrom
Conversation
Check if existing unofficial chapter is now official, if so mark as not downloaded.
|
Actually in hindsight to test this, I could add a PATCH endpoint to I'm going afk for a bit, but I might write that up and test it when I return. |
|
It works! I think this one is g2g! |
|
The only thing I think that could be left to test is pushing this to a live database with existing data. It should update existing chapters with their current official status from WeebCentral, but not redownload anything since it is going from NULL to TRUE/FALSE. Note: If a chapter was previously downloaded as unofficial but has since been replaced on WeebCentral with an official version, its IsOfficial flag will be set to TRUE; even though the local copy remains unofficial. To trigger a re-download on the next check, one would need to manually set IsOfficial back to FALSE. |
|
Hi I have been and am quiet occupied until Wednesday at least, so give me a bit longer to look at all of this! |
|
No worries, brother. Whenever you get time, no rush 😁 |
Added logic for cases where `IsOfficial` is NULL and `incomingChapter` is TRUE/FALSE. NULL to TRUE/FALSE do not re-download since there is no way to know whether existing chapter is official or not.
|
I got around to testing this with a copy of my existing database. I added logic for cases where Logic is to only update the |
Fixes #333.
isOfficialto chapter; null by default.RetrieveMangaChaptersFromMangaconnectorWorkerto check if existing unofficial chapter is now official. If so, mark as not downloaded to queue to be downloaded.NOTE: Everything works for
isOfficial, but I have not tested the checking of existing chapters part; of the manga I have in my queue, the closest new official volume release is April :( If you have a better way to test this, please let me know!Potential future enhancements:
StartNewChapterDownloadsWorkerfor "Found # chapters available for upgrade to official."