fix: jj 0.33.0 and Rust 1.89.0 compatibility #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's a new warning in Rust 1.89.0.
e1d27a8 to
889e99d
Compare
Collaborator
Author
|
@istudyatuni @Cretezy could one of you have a look here? This is a major blocker right now. Thank you! |
3 tasks
Collaborator
|
Sadly no rebase merge 😢 |
istudyatuni
reviewed
Sep 9, 2025
889e99d to
062e1a4
Compare
istudyatuni
approved these changes
Sep 9, 2025
--config-toml has been removed so we need to use --config instead, which has a bit stricter format requirements. No leading/trailing new lines, and no spaces around the equal sign. It can also only take a single option at a time, so we need to change jj_config_toml from a String to a Vec<String>. And for obslog/evolog, the template format has changed, so we need to update that as well.
062e1a4 to
da8591c
Compare
|
Thanks for the fix! Could you please consider making a minor release? |
Collaborator
|
Sadly we can't, we need an action from @Cretezy |
Collaborator
|
Oh, turns out we can |
Cool! I'll be waiting for it then :) |
Collaborator
|
What a coincidence, I published it 5 minutes ago |
|
Thanks! However, you forgot to update the version number in |
Collaborator
|
Thanks! Fixed in v0.6.1 |
Indeed, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--config-toml has been removed so we need to use --config instead, which has a bit stricter format requirements. No leading/trailing new lines, and no spaces around the equal sign.
It can also only take a single option at a time, so we need to change jj_config_toml from a String to a Vec.
And for obslog/evolog, the template format has changed, so we need to
update that as well.