Fix invalid syntax in menu! docs
#828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGES.md diff --git c/CHANGES.md i/CHANGES.md index 3562c70..c57ab89 100644 --- c/CHANGES.md +++ i/CHANGES.md @@ -11,6 +11,7 @@ + all: Update dependencies + core: Add gnome_49 feature flag for GNOME 49 + core: Export `RelmSelectionExt` trait publicly from `relm4::typed_view` module to allow for user extensions of `TypedColumnView` ++ docs: Fix invalid syntax in `menu!` documentation ## 0.10.0 - 2025-09-01 diff --git c/relm4-macros/src/lib.rs i/relm4-macros/src/lib.rs index df04068..fe9e065 100644 --- c/relm4-macros/src/lib.rs +++ i/relm4-macros/src/lib.rs @@ -234,7 +234,7 @@ pub fn component(attributes: TokenStream, input: TokenStream) -> TokenStream { /// type Input = CounterMsg; /// type Output = CounterOutput; /// type ParentWidget = gtk::Box; -/// +/// /// /// view! { /// root = gtk::Box { @@ -313,7 +313,7 @@ pub fn factory(attributes: TokenStream, input: TokenStream) -> TokenStream { /// /// + `"Label text" => ActionType,` to create new entries. /// + `"Label text" => ActionType(value),` to create new entries with action value. -/// + `custom => "widget_id",` add a placeholder for custom widgets you can add later with [`set_attribute_name`](https://gtk-rs.org/gtk-rs-core/stable/0.15/docs/gio/struct.MenuItem.html#method.set_attribute_value). +/// + `custom: "widget_id",` to add a placeholder for custom widgets you can add later with [`set_attribute_name`](https://gtk-rs.org/gtk-rs-core/stable/0.15/docs/gio/struct.MenuItem.html#method.set_attribute_value). /// + `section! { ... }` to create new sections. /// /// # Example
AaronErhardt
approved these changes
Dec 26, 2025
Contributor
|
Relm4/docs#12 fixed docs deployment. So, now your docs fix is on next docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The doc comment for the
menu!macro incorrectly stated that the custom widget syntax wascustom => "name"rather thancustom: "name". This PR corrects the error.Trailing spaces on line 237 were stripped automatically when I formatted the file.
Checklist