[Enhancement] support prune partitions in be #68141

Seaven · 2026-01-20T03:44:23Z

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
- This pr needs auto generate documentation
This is a backport pr

Bugfix cherry-pick branch check:

Signed-off-by: Seaven <[email protected]>

StarRocks-Reviewer · 2026-01-20T03:46:59Z

@cursor review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eeec80aaf8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

fe/fe-core/src/main/java/com/starrocks/sql/plan/PlanFragmentBuilder.java

cursor

Cursor Bugbot has reviewed your changes and found 4 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

fe/fe-core/src/main/java/com/starrocks/sql/plan/PlanFragmentBuilder.java

be/src/exec/olap_scan_node.cpp

Signed-off-by: Seaven <[email protected]>

alvin-celerdata · 2026-01-20T17:49:10Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a7acd51954

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-01-20T17:54:51Z

fe/fe-core/src/main/java/com/starrocks/sql/plan/PlanFragmentBuilder.java

+                    return List.of();
+                }
+
+                Preconditions.checkState(partitionValuesList.size() == partitionCols.size());


Fix list-partition range handling for multi-column values

In computePartitionRange the list-partition branch treats partitionValuesList as if its outer size equals the number of partition columns, but ListPartitionInfo.getMultiLiteralExprValues() returns a list of rows (each inner list contains values for all partition columns). That means Preconditions.checkState(partitionValuesList.size() == partitionCols.size()) will throw for typical multi-column list partitions (e.g., 2 columns with >2 list values), causing planning to fail as soon as partition pruning is enabled. Even if the sizes happen to match, the subsequent partitionValuesList.get(i) is a row, not the list of values for column i, so the TKeyRange values are misassigned. This should pivot rows into per-column lists (or validate inner list sizes) before building list_values.

Useful? React with 👍 / 👎.

Signed-off-by: Seaven <[email protected]>

sonarqubecloud · 2026-01-21T03:38:01Z

Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Signed-off-by: Seaven <[email protected]>

github-actions · 2026-01-21T06:31:59Z

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2026-01-21T06:36:15Z

[BE Incremental Coverage Report]

❌ fail : 0 / 91 (00.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	be/src/exec/olap_scan_node.cpp	0	91	00.00%	[123, 124, 125, 126, 127, 131, 132, 433, 435, 436, 437, 438, 439, 441, 442, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 456, 457, 458, 459, 461, 462, 463, 464, 465, 466, 468, 469, 470, 471, 474, 475, 479, 481, 482, 483, 486, 487, 489, 490, 493, 494, 495, 496, 497, 498, 499, 503, 504, 505, 508, 509, 511, 512, 513, 515, 516, 517, 518, 520, 521, 522, 524, 525, 529, 530, 531, 532, 533, 536, 537, 539, 540, 543, 544, 545, 552, 554, 555, 560, 604]

alvin-celerdata · 2026-01-25T18:58:13Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c54873424d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

be/src/exec/olap_scan_node.cpp

Seaven requested a review from a team as a code owner January 20, 2026 03:44

wanpengfei-git added the PROTO-REVIEW label Jan 20, 2026

wanpengfei-git requested a review from a team January 20, 2026 03:44

mergify bot assigned Seaven Jan 20, 2026

Seaven added 2 commits January 20, 2026 11:45

[Enhancement] support prune partitions in be

907e927

Signed-off-by: Seaven <[email protected]>

update ut

78af9db

Signed-off-by: Seaven <[email protected]>

Seaven force-pushed the part branch from eeec80a to 78af9db Compare January 20, 2026 03:45

chatgpt-codex-connector bot reviewed Jan 20, 2026

View reviewed changes

fe/fe-core/src/main/java/com/starrocks/sql/plan/PlanFragmentBuilder.java Outdated Show resolved Hide resolved

cursor bot reviewed Jan 20, 2026

View reviewed changes

fix style

a7acd51

Signed-off-by: Seaven <[email protected]>

chatgpt-codex-connector bot reviewed Jan 20, 2026

View reviewed changes

Seaven added 3 commits January 21, 2026 10:21

update

0e36a8a

Signed-off-by: Seaven <[email protected]>

fix list partition

20e2308

Signed-off-by: Seaven <[email protected]>

fix

5920ae4

Signed-off-by: Seaven <[email protected]>

Seaven added 2 commits January 21, 2026 11:46

fix be

295440f

Signed-off-by: Seaven <[email protected]>

m

c548734

Signed-off-by: Seaven <[email protected]>

chatgpt-codex-connector bot reviewed Jan 25, 2026

View reviewed changes

be/src/exec/olap_scan_node.cpp Show resolved Hide resolved

[Enhancement] support prune partitions in be #68141

Are you sure you want to change the base?

[Enhancement] support prune partitions in be #68141

Conversation

Seaven commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

Uh oh!

StarRocks-Reviewer commented Jan 20, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alvin-celerdata commented Jan 20, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jan 21, 2026

Quality Gate passed

Uh oh!

github-actions bot commented Jan 21, 2026

[Java-Extensions Incremental Coverage Report]

Uh oh!

github-actions bot commented Jan 21, 2026

[BE Incremental Coverage Report]

file detail

Uh oh!

alvin-celerdata commented Jan 25, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Seaven commented Jan 20, 2026 •

edited

Loading