feat(domain): Phase 1 Core Domain Model for v5 Architecture #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement P1.1 domain scaffolding with SimulationConfig as the first typed domain object, replacing untyped engine_props dictionaries. Changes include: - Create fusion/domain/ package structure - Implement SimulationConfig frozen dataclass with full validation - Add bidirectional adapters (from_engine_props, to_engine_props) - Include all fields from P1.0 gap analysis: - Network/topology configuration - Physical layer parameters (from RoutingProps, SNRProps) - Protection configuration (from SDNProps) - Modulation mappings and SNR thresholds - Add computed properties (total_slots, arrival_rate, is_multiband, etc.) - Achieve 100% test coverage with 45 tests 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Implements P1.2 Request Wrapper sub-phase with complete domain model: - RequestType enum (ARRIVAL, RELEASE) with legacy adapters - RequestStatus enum (10 states) with transition validation - BlockReason enum (13 values) with categorization helpers - ProtectionStatus enum (8 states) for 1+1 protection tracking - Request dataclass with lifecycle methods and legacy conversion All implementations include from_legacy/to_legacy adapters for migration. 107 tests with 100% coverage. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
… architecture (P1.3) Implements the Lightpath domain model as part of Phase 1 Core Domain: - Mutable dataclass with 21 fields (identity, spectrum, capacity, quality, protection) - Validation in __post_init__ for path length, slot range, bandwidth invariants - 9 computed properties (source, destination, endpoint_key, utilization, etc.) - Capacity management methods (allocate_bandwidth, release_bandwidth, can_accommodate) - 1+1 protection support (switch_to_backup, switch_to_primary, current_path) - Legacy adapters (from_legacy_dict, to_legacy_dict, to_legacy_key) - 71 comprehensive tests with 100% code coverage 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Add 7 frozen result dataclasses per P1.4 specification with P1.0 gap analysis: - RouteResult: routing pipeline output with backup path support - SpectrumResult: spectrum assignment with backup spectrum fields - GroomingResult: grooming pipeline with partial grooming support - SlicingResult: slicing pipeline with multi-lightpath tracking - SNRResult: SNR validation with per-link breakdown - ProtectionResult: 1+1 protection establishment and switchover (G4.1) - AllocationResult: final authority with per-segment tracking fields AllocationResult includes per-segment fields per P1.0.a section 5.3: bandwidth_allocations, modulations, cores, bands, start_slots, end_slots, xt_costs, xt_values, snr_values, lightpath_bandwidths All result objects are immutable (frozen dataclasses) with: - Factory methods for common creation patterns - Legacy conversion methods (from_routing_props, from_spectrum_props) - Validation in __post_init__ for invariants - Comprehensive docstrings with examples Test coverage: 82 tests, 234 total domain tests passing 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Add centralized statistics collection that consumes domain objects and produces metrics compatible with run_comparison.py. StatsCollector tracks: - Request counters (total, successful, blocked) - Block reasons with BlockReason enum integration - Feature usage (grooming, slicing, protection) - Modulation and band/core usage distribution - SNR and crosstalk values - Path metrics (hops, lengths) - Protection statistics (switchovers, failures) Key methods: - record_arrival(request, result) - main recording entry - record_snr/record_xt - explicit metric recording - to_comparison_format() - run_comparison.py export - to_legacy_stats_dict() - legacy StatsProps compatibility - merge() - combine parallel simulation results Test coverage: 97% with 61 tests 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Pull Request
Related Feature Request: Phase 1 Core Domain Model for v5 Architecture
Feature Summary: Implements the complete Phase 1 core domain model for FUSION v5 architecture, establishing typed dataclasses that replace legacy Props classes with immutable, well-typed domain objects.
Implementation Details
Components Added/Modified:
fusion/domain/) - New domain packagefusion/stats/) - New stats packagefusion/tests/) - Comprehensive test coverageNew Files Created:
New Dependencies: None
Testing
Coverage Summary:
fusion/domain/config.pyfusion/domain/request.pyfusion/domain/lightpath.pyfusion/domain/results.pyfusion/stats/collector.pyCommits Included
ec74467487a3d41458a494838191384c3c301247Backward Compatibility
Checklist
Reviewer Notes
Focus Areas:
Known Limitations:
record_release()is a no-op in Phase 1 (placeholder)Next Steps:
🤖 Generated with Claude Code