feat(domain): add Phase 2 State Management for v5 architecture #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…P2.1) Implement Phase 2.1 NetworkState Core - the single source of truth for network state during simulation. LinkSpectrum dataclass: - Per-link spectrum management with multi-band/multi-core support - Spectrum allocation with guard band convention (negative IDs) - Fragmentation ratio calculation NetworkState class: - Centralized state container for topology, spectrum, and lightpaths - Read-only methods: get_lightpath, is_spectrum_available, find_first_fit - Bidirectional link handling (same LinkSpectrum for both directions) - State authority mapping per P2.0 gap analysis 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
… architecture (P2.2) Add state mutation capabilities to NetworkState: - create_lightpath(): Create and register lightpaths with spectrum allocation - release_lightpath(): Release lightpaths and free spectrum - allocate_request_bandwidth(): Bandwidth management for grooming - release_request_bandwidth(): Release bandwidth allocations Add legacy compatibility properties (temporary migration shims): - network_spectrum_dict: Returns spectrum state in sdn_props format - lightpath_status_dict: Returns lightpath state in sdn_props format Features: - Guard band support (negative IDs for guard slots) - 1+1 protection support (primary + backup paths) - SNR and crosstalk value tracking - Complete field mapping from P2.0 gap analysis 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Add type-safe Protocol definitions for all pipeline components: - RoutingPipeline: find_routes() with forced_path support - SpectrumPipeline: find_spectrum(), find_protected_spectrum() - GroomingPipeline: try_groom(), rollback_groom() - SNRPipeline: validate(), recheck_affected() (per gap analysis) - SlicingPipeline: try_slice() with optional params, rollback_slices() Also adds SNRRecheckResult for SNR recheck operations after new lightpath allocation (identified in P2.0 gap analysis). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Implement adapter classes that wrap legacy implementations to satisfy the new pipeline protocols from P2.3, enabling gradual migration to the v5 architecture. Adapters implemented: - RoutingAdapter: wraps legacy Routing class, implements RoutingPipeline - SpectrumAdapter: wraps legacy SpectrumAssignment, implements SpectrumPipeline - GroomingAdapter: wraps legacy Grooming, implements GroomingPipeline - SNRAdapter: wraps legacy SnrMeasurements, implements SNRPipeline Key design decisions: - Stateless pattern: fresh state per call, no carryover between calls - SDNPropsProxy objects provide read-only access to NetworkState - Adapters handle exceptions gracefully, returning appropriate results - All adapters include removal checklists for Phase 4 cleanup - Type-safe with isinstance checks for backup path handling 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Pull Request
Related Feature Request:
Part of v5 architecture refactoring initiative
Feature Summary:
Implements Phase 2 (State Management) of the v5 architecture, providing centralized network state management, pipeline protocols, and legacy adapters for gradual migration.
Implementation Details
Components Added/Modified:
fusion/core/)tests/)New Files Created:
fusion/domain/network_state.pyfusion/domain/results.pyfusion/interfaces/pipelines.pyfusion/core/adapters/__init__.pyfusion/core/adapters/routing_adapter.pyfusion/core/adapters/spectrum_adapter.pyfusion/core/adapters/grooming_adapter.pyfusion/core/adapters/snr_adapter.pyNew Dependencies: None
Configuration Changes: None
Phase 2 Sub-phases Completed
b3609f65e4b880b20449d569042f7935Testing
New Test Coverage:
Test Files Added:
fusion/domain/tests/test_network_state.py(1978 lines)fusion/domain/tests/test_results.py(85 lines)fusion/interfaces/tests/test_pipelines.py(525 lines)fusion/tests/adapters/test_routing_adapter.py(196 lines)fusion/tests/adapters/test_spectrum_adapter.py(243 lines)fusion/tests/adapters/test_grooming_adapter.py(277 lines)fusion/tests/adapters/test_snr_adapter.py(275 lines)fusion/tests/adapters/test_all_adapters.py(152 lines)Manual Testing Steps:
pytest fusion/domain/tests/ -vpytest fusion/interfaces/tests/ -vpytest fusion/tests/adapters/ -vPerformance Impact
Benchmarks:
Documentation
Documentation Added/Updated:
Key Design Decisions:
Backward Compatibility
Compatibility Impact:
Legacy code remains unchanged. New components can be adopted incrementally through adapters.
Checklist
Core Implementation:
Integration:
Quality Assurance:
Reviewer Notes
Focus Areas for Review:
network_spectrum_dict,lightpath_status_dict)Known Limitations:
Future Enhancements:
🤖 Generated with Claude Code