Thanks to visit codestin.com
Credit goes to Github.com

Skip to content

Improve CSTR model #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ZedongPeng wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve CSTR model #56

ZedongPeng wants to merge 1 commit into from

Conversation

@ZedongPeng
Copy link
Member

@ZedongPeng ZedongPeng commented Aug 21, 2024

Changes

  • Remove the redundant boolean variables in the CSTR model.

bernalde
bernalde requested changes Aug 21, 2024
View reviewed changes
Copy link
Member

@bernalde bernalde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like you to review if this model can be solved by LOA as it looks similar to the changes that I made earlier with @AlbertLee125 that would fail in that.
More importantly, there are issues that are being resolved with the model right now so I would hold from merging these until we are clear in that front

@bernalde
Copy link
Member

bernalde commented Jan 23, 2025

@AlbertLee125 any news?

@AlbertLee125
Copy link
Member

AlbertLee125 commented Jan 24, 2025 

if __name__ == "__main__":
    m = build_model(NT=5)
    subsolver = 'scip'
    pyo.SolverFactory("gdpopt.loa").solve(
        m,
        tee=True,
        nlp_solver=subsolver,
        mip_solver=subsolver,
        minlp_solver=subsolver,
        local_minlp_solver=subsolver,
    )

Running the reformed code with the given script. The model can be solved by LOA and the objective found by LOA is similar to the objective solved by GDP reformulation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bernalde bernalde bernalde requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@AlbertLee125 AlbertLee125

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ZedongPeng @bernalde @AlbertLee125