Fix missing sstream include #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/c_boost/expr/ast_common.hpp makes use of std::istringstream, but does not include <sstream>. Some boost header must have silently pulled in sstream, but as of boost 1.84 that no longer happens. Trying to build XDM with boost 1.84 fails as a result. This commit makes ast_common.hpp include <sstream> itself, and that fixes the problem.
Collaborator
|
Thanks for the info and the fix. I'm still on boost 1.81 but I'll confirm and get a fix for the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/c_boost/expr/ast_common.hpp makes use of std::istringstream, but does not include <sstream>.
Some boost header must have silently pulled in sstream, but as of boost 1.84 that no longer happens. Trying to build XDM with boost 1.84 fails as a result.
This commit makes ast_common.hpp include <sstream> itself, and that fixes the problem.
Tagging @Karlsefni2012 @gjtempl @TBird2001 directly so they see this sooner.
Closes GH-11
(hint, if you use
git format-patch master..fixsstreamon this repo or simply access https://github.com/Xyce/XDM/pull/12.patch , you can get a patch file you can insert into the official repo withgit am)