Open
Conversation
mhvk
reviewed
Oct 25, 2025
Owner
mhvk
left a comment
There was a problem hiding this comment.
Thanks! This looks good but I suggest two small edits inside.
docs/tutorials/using_baseband.rst
Outdated
| } | ||
|
|
||
| To remove these extra scalings, one can simply remove the ``OPTIMAL_2BIT_HIGH`` or | ||
| ``FOUR_BIT_1_SIGMA``. |
Owner
There was a problem hiding this comment.
I would add an explicit example here, like
``FOUR_BIT_1_SIGMA``. For instance, to have 4-bit data return values between -8 and 7,
you can do the following prior to reading a file::
baseband.base.encoding.decoder_levels[4] = np.arange(16, dtype=np.float32) - 8.
docs/tutorials/using_baseband.rst
Outdated
| Changing scaling when decoding data | ||
| =================================== | ||
|
|
||
| In vdif, mark4 and mark5b data formats, the lookup tables for their decoding are defined using |
Owner
There was a problem hiding this comment.
Maybe rewrite slightly. "... formats, the data are decoded using lookup tables, which are the same
as those used by mark5access. These are defined in ..."
Owner
|
@atkinson153 - am happy with this, but have one last request: could you ensure that the lines do not exceed ~80 characters, as in the rest of the text. With that, ready to go in! |
Author
|
Thanks for the feedback Marten! I just changed the lines so they don't exceed ~80 characters. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added info on how to remove scaling factors as discussed.