Thanks to visit codestin.com
Credit goes to Github.com

Skip to content
This repository was archived by the owner on Jun 19, 2025. It is now read-only.

Verbose vault logging #502

Open
ramondeklein wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Verbose vault logging #502

ramondeklein wants to merge 8 commits into from
+113 −10

Conversation

@ramondeklein
Copy link
Contributor

@ramondeklein ramondeklein commented Jan 13, 2025

This PR adds the following functionality:

  • Always log Vault authentication failures.
  • Enable verbose Vault HTTP logging by setting .keystore.vault.verbose to true (default is disabled).

@ramondeklein ramondeklein self-assigned this Jan 13, 2025
@ramondeklein ramondeklein force-pushed the verbose-vault-logging branch 3 times, most recently from 92eac4f to 7b779b6 Compare January 13, 2025 15:43
ramondeklein
ramondeklein commented Jan 13, 2025
View reviewed changes
@ramondeklein ramondeklein requested a review from aead January 13, 2025 16:42
@ramondeklein ramondeklein marked this pull request as ready for review January 13, 2025 16:42
@ramondeklein ramondeklein force-pushed the verbose-vault-logging branch 3 times, most recently from 0cffa26 to 8295cbf Compare January 13, 2025 16:53
aead
aead suggested changes Jan 29, 2025
View reviewed changes
Copy link
Member

@aead aead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, without the additional config field

@aead aead force-pushed the verbose-vault-logging branch from 8295cbf to 2c90351 Compare January 30, 2025 09:29
@ramondeklein ramondeklein force-pushed the verbose-vault-logging branch from 2c90351 to efb88c5 Compare February 3, 2025 11:19
@ramondeklein ramondeklein force-pushed the verbose-vault-logging branch from b673e09 to 9e44368 Compare February 3, 2025 11:45
@ramondeklein
Copy link
Contributor Author

ramondeklein commented Feb 3, 2025

I processed the review comments. I find it kind of nasty to use slog.Default(), but the logger (or log-level) isn't available from the actual Store implementation.

@ramondeklein ramondeklein requested a review from aead February 3, 2025 12:10
@ramondeklein
Copy link
Contributor Author

ramondeklein commented May 22, 2025

@aead Not sure if we still need this. If not, then close. Otherwise please review...

@harshavardhana harshavardhana force-pushed the master branch 3 times, most recently from f832434 to 63649d0 Compare May 27, 2025 18:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aead aead Awaiting requested review from aead

At least 1 approving review is required to merge this pull request.

Assignees

@ramondeklein ramondeklein

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ramondeklein @aead