fix: prevent confirmVerified(vararg mocks) from clearing unrelated mocks #1381
Conversation
|
|
||
| MockKGateway.implementation().clearer.clearAll(options, currentThreadOnly = true) | ||
| if (mocks.isEmpty()) { | ||
| implementation.clearer.clearAll(options, false) |
There was a problem hiding this comment.
Why was this changed from true to false?
There was a problem hiding this comment.
To be honest, I’m not entirely sure which value is more appropriate here. I noticed that clearAllMocks by default uses currentThreadOnly = false, so I followed that behavior for consistency. But if there's a specific reason it should be true, I’m happy to revisit this.
|
Wild guess: could it be that Can you check the values of |
I don’t think that’s the root cause, because when the confirmVerifiedAll test is run in isolation, it passes — so it seems that verify { ... } with multiple calls is working as expected in that context. However, when the whole test suite is executed, the same test fails. That suggests some shared state leakage or interference between tests, similar to what we saw before the fix for #821.
Yes — I added debug prints and here’s what I found during a failing run (screenshot attached below). So it looks like the verifiedCalls list gets cleared unexpectedly across tests. Interestingly, if I add a clearAllMocks() at the beginning of the confirmVerifiedAll test, it passes — just like it used to before PR #1367. |
|
That's interesting - I'd do more investigation to understand who's clearing the verifiedCalls list, when and why :) |
🚧 Draft Pull Request – Partial Fix for Issue #1379
This PR builds upon the changes introduced in #821, aiming to improve test isolation while addressing the regression reported in #1379.
🛠 What's Being Done
internalConfirmVerifiedto reset only the specified mocks when parameters are passed.resetVerificationStateto selectively clear verification state for specific mocks.try-finally, making the verification process more robust.confirmVerifiedSpecificMockto verify thatconfirmVerified(mock)behavior is correct.This PR is still in progress. While the targeted clearing works in isolated tests, the test suite fails when running
confirmVerifiedAll.This issue appears similar to the cross-test interference previously addressed in issue #821, but now occurs when
confirmVerifiedis used without parameters after using it with specific mocks in other tests.👉 Notably, if we add a
clearAllMocks()call before theconfirmVerifiedAlltest, it passes successfully — just like it did before PR #1367.🔍 Next Steps
Investigate and resolve the failure of
confirmVerifiedAllin the full test suite@Raibaz do you have any idea why this might be happening? It seems related to state retention when mixing
confirmVerified(mock)andconfirmVerified()in different tests.