This repository was archived by the owner on Jan 10, 2018. It is now read-only.
feat(models): make action a generic type#382
Open
valorkin wants to merge 1 commit intongrx:masterfrom
valorkin:patch-1
Open
feat(models): make action a generic type#382valorkin wants to merge 1 commit intongrx:masterfrom valorkin:patch-1
valorkin wants to merge 1 commit intongrx:masterfrom
valorkin:patch-1
Conversation
This is not an actual PR, more like proposal for consideration Typesafe maniac like would be really greatful for strictly typed Action TS v2.2+ introduces defaults for generic types so `Action<T = any>` means Action is generic, but it will be any if type not provided
Author
|
This feature just landed in ts 2.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not an actual PR, more like proposal for consideration
Typesafe maniac like would be really grateful for strictly typed Action
TS v2.2+ introduces defaults for generic types
so
Action<T = any>means Action is generic, but it will be any if type not providedWhat do you think?
TS proposal here:
microsoft/TypeScript#2175