Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @MC-luoluo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the 'Extra Stats' dungeon module by introducing a suite of new configurable options and expanding the range of statistics displayed at the end of a dungeon run. It provides users with more detailed insights into their performance and team contributions, alongside improved readability for large numerical values.
Highlights
- Configurability: The 'Extra Stats' module now offers extensive configuration options, allowing users to toggle the display of bits earned, class experience, combat statistics (damage, healing, enemy kills), and choose how team statistics are presented (Off, Personal, Team, Both). An option to show teammates has also been added.
- Expanded Statistics Display: The end-of-dungeon summary now includes a wider range of statistics such as bits earned, detailed combat stats (total damage, ally healing, enemies killed, including personal best indicators), and personal deaths. These are dynamically displayed based on user preferences.
- Improved Data Capture: New chat message listeners have been implemented to accurately parse and extract additional data points like bits, combat statistics, and personal deaths from the game's chat output, ensuring comprehensive data collection for the enhanced display.
- Number Formatting Utility: A new utility function,
formatNumber, has been introduced inUtils.ktto automatically format large numerical values (e.g., damage, healing) into a more readable 'K', 'M', or 'B' (thousands, millions, billions) format, improving the clarity of displayed statistics.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request adds more stats and configurability to the Extra Stats feature. The changes are well-implemented, but there are a few areas for improvement. I've identified a critical bug in the new formatNumber utility that could lead to a crash, and I've suggested a fix. I've also provided feedback to improve code readability, consistency, and performance in both the feature and utility code. Overall, a solid update that will be even better with these changes.
src/main/kotlin/me/odinmain/features/impl/dungeon/ExtraStats.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/me/odinmain/features/impl/dungeon/ExtraStats.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: MCluoluo <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: MCluoluo <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: MCluoluo <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: MCluoluo <[email protected]>
|
Please fix compile errors |
Made Extra Stats have more stats and configurable
Default configuration effect diagram:



