Vivado flow now adds synth arg if pnr is none #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this not caused by the build method in the vivado tool class? edalize/edalize/tools/vivado.py Lines 280 to 288 in 7f5efda "synth" is appended to |
Owner
|
Good catch. Does it work as expected if you just change args.append to self.args.append (or return args)? |
Contributor
Author
|
afaik the vivado tool build method never gets called using the flow api. This is the inherited build method from edaflow edalize/edalize/flows/edaflow.py Lines 368 to 370 in 8c74627 It gets the build command (by default make) and the build args (which currently cant be set for the make builder #480 ). And then executes that with _run_tool() which is just a wrapper for subprocess.run() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #479. The idea is to override the inherited build method so it properly accounts for the pnr option and appends the synth argument when is needed, basically mirroring how it’s handled in the Vivado tool code.