Thanks to visit codestin.com
Credit goes to Github.com

Skip to content

Conversation

@Icarus9913
Copy link
Contributor

close #1620

@onsi
Copy link
Owner

onsi commented Jan 11, 2026

hey @Icarus9913 would you like me to look at this and share thoughts/feedback? Or are you still working your way through it? btw one of the test runs failed on go vet

@Icarus9913
Copy link
Contributor Author

hey @Icarus9913 would you like me to look at this and share thoughts/feedback? Or are you still working your way through it? btw one of the test runs failed on go vet

Hey @onsi , the PR is not finished yet. There're still some places need to be improved and I also need to write the tests. I think that I can have deep understanding on the codes when I supplement the tests and know the improvements/shortage about the codes.
I'll ping you once the PR is ready :)

@Icarus9913 Icarus9913 force-pushed the feat/icarus/components-sem-ver branch from 3d37474 to 0842943 Compare January 18, 2026 11:31
@Icarus9913 Icarus9913 changed the title [WIP] feat: support component semantic version filtering feat: support component semantic version filtering Jan 18, 2026
@Icarus9913 Icarus9913 force-pushed the feat/icarus/components-sem-ver branch 3 times, most recently from dac7567 to 69b2f78 Compare January 18, 2026 14:40
@Icarus9913 Icarus9913 force-pushed the feat/icarus/components-sem-ver branch from 69b2f78 to f5d58b1 Compare January 18, 2026 14:41
@Icarus9913 Icarus9913 marked this pull request as ready for review January 18, 2026 14:45
@Icarus9913
Copy link
Contributor Author

@onsi Hey onsi, sorry for the late. I've been occupied with my job.
Now I think the PR is ready, could you please have a look and share your thoughts? By the way, you can check the e2e tests code and doc for the start, then you would have better context :)

@Icarus9913
Copy link
Contributor Author

Hey @pohly , you can also have a look at the unit-tests to check if it satisfies your requirement :)

@onsi
Copy link
Owner

onsi commented Jan 22, 2026

Thank @Icarus9913 I'll aim to take a look soon!

Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API and usage look good to me.

@onsi
Copy link
Owner

onsi commented Jan 30, 2026

so sorry for the delay! this looks great! thanks so much @Icarus9913 will pull it in and cut a release

@onsi onsi merged commit 71d2d89 into onsi:master Jan 30, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support semantic version filter for multiple components

3 participants