-
-
Notifications
You must be signed in to change notification settings - Fork 692
feat: support component semantic version filtering #1635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
hey @Icarus9913 would you like me to look at this and share thoughts/feedback? Or are you still working your way through it? btw one of the test runs failed on |
Hey @onsi , the PR is not finished yet. There're still some places need to be improved and I also need to write the tests. I think that I can have deep understanding on the codes when I supplement the tests and know the improvements/shortage about the codes. |
3d37474 to
0842943
Compare
dac7567 to
69b2f78
Compare
Signed-off-by: Icarus Wu <[email protected]>
69b2f78 to
f5d58b1
Compare
|
@onsi Hey onsi, sorry for the late. I've been occupied with my job. |
|
Hey @pohly , you can also have a look at the unit-tests to check if it satisfies your requirement :) |
|
Thank @Icarus9913 I'll aim to take a look soon! |
pohly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API and usage look good to me.
|
so sorry for the delay! this looks great! thanks so much @Icarus9913 will pull it in and cut a release |
close #1620