[Fix]: fix mim command crashes problem if requirements version conflict#144
Open
ice-tong wants to merge 2 commits intoopen-mmlab:mainfrom
Open
[Fix]: fix mim command crashes problem if requirements version conflict#144ice-tong wants to merge 2 commits intoopen-mmlab:mainfrom
ice-tong wants to merge 2 commits intoopen-mmlab:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #144 +/- ##
==========================================
+ Coverage 54.44% 54.50% +0.05%
==========================================
Files 23 23
Lines 1552 1554 +2
Branches 331 331
==========================================
+ Hits 845 847 +2
Misses 582 582
Partials 125 125
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
… version conflict
7e58407 to
7eed082
Compare
Collaborator
Author
|
This workaround works fine, but I'm not sure if good enough to merge into the master branch. Please give this PR a review. @zhouzaida |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Fixes #143 that mim could be crash if exist version conflict.
For reproduce mim crash:
Modification
mim/__init__.py: set__requires__in__main__module from 'openmim' to '' avoid requirement resolve check.BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist